Skip to content

redis_proxy: Add support for HEXPIRE and related commands in Redis fi…#44887

Open
alrzazz wants to merge 4 commits into
envoyproxy:mainfrom
alrzazz:main
Open

redis_proxy: Add support for HEXPIRE and related commands in Redis fi…#44887
alrzazz wants to merge 4 commits into
envoyproxy:mainfrom
alrzazz:main

Conversation

@alrzazz
Copy link
Copy Markdown

@alrzazz alrzazz commented May 6, 2026

Commit Message:
redis_proxy: Add support for HEXPIRE and related commands in Redis filter

Copilot AI review requested due to automatic review settings May 6, 2026 12:14
@repokitteh-read-only
Copy link
Copy Markdown

Hi @alrzazz, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #44887 was opened by alrzazz.

see: more, trace.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends Envoy’s redis_proxy network filter command allowlist to recognize Redis hash field expiration commands (e.g., HEXPIRE and related variants), and updates tests/docs/release notes accordingly.

Changes:

  • Added hash-field-expiration commands to the Redis proxy supported command sets (and write-command classification where applicable).
  • Added a unit test covering a successful HEXPIRE request path and its per-command stats.
  • Updated Redis protocol documentation and current.yaml release notes to reflect the new command support.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/extensions/filters/network/redis_proxy/command_splitter_impl_test.cc Adds a HEXPIRE success test validating per-command stats/histogram behavior.
source/extensions/filters/network/common/redis/supported_commands.h Adds HEXPIRE-family commands to supported command sets and write-command classification.
docs/root/intro/arch_overview/other_protocols/redis.rst Documents the newly supported hash-field-expiration commands in the supported-command table.
changelogs/current.yaml Adds a release note entry describing the new Redis command support.

Comment thread source/extensions/filters/network/common/redis/supported_commands.h Outdated
Comment thread changelogs/current.yaml Outdated
@alrzazz alrzazz had a problem deploying to external-contributors May 6, 2026 13:33 — with GitHub Actions Error
@alrzazz alrzazz had a problem deploying to external-contributors May 9, 2026 07:06 — with GitHub Actions Error
@nezdolik
Copy link
Copy Markdown
Member

/gemini review

@nezdolik
Copy link
Copy Markdown
Member

Please fix DCO

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Redis 7.4 hash field expiration commands, including HEXPIRE, HEXPIREAT, HPERSIST, HPEXPIRE, HPEXPIREAT, HPTTL, and HTTL, within the redis_proxy network filter. The changes encompass command registration, documentation updates, and comprehensive unit tests for command classification and execution. Feedback from the review suggests including HEXPIRETIME and HPEXPIRETIME for completeness across the supported commands list, documentation, and test suites.

Comment thread source/extensions/filters/network/common/redis/supported_commands.h Outdated
Comment thread docs/root/intro/arch_overview/other_protocols/redis.rst
Comment thread docs/root/intro/arch_overview/other_protocols/redis.rst
Comment thread test/extensions/filters/network/redis_proxy/command_splitter_impl_test.cc Outdated
@kyessenov
Copy link
Copy Markdown
Contributor

/wait

@alrzazz
Copy link
Copy Markdown
Author

alrzazz commented May 13, 2026

/wait

hi
all comments are resolved

nezdolik
nezdolik previously approved these changes May 19, 2026
Comment thread changelogs/current.yaml Outdated
alrzazz and others added 4 commits May 20, 2026 18:05
Signed-off-by: Alireza <alrzazz98@gmail.com>
…lter

Signed-off-by: Alireza <alrzazz98@gmail.com>
…PERSIST, HTTL, and HPTTL commands

Signed-off-by: Alireza <alrzazz98@gmail.com>
Signed-off-by: Alireza <alrzazz98@gmail.com>
@alrzazz
Copy link
Copy Markdown
Author

alrzazz commented May 20, 2026

Apologies for all the mentions. I’ve restored the commits and added everything required for this pull request. If the history or changes feel too messy, I can recreate the PR from scratch to keep things cleaner and easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants