redis_proxy: Add support for HEXPIRE and related commands in Redis fi…#44887
redis_proxy: Add support for HEXPIRE and related commands in Redis fi…#44887alrzazz wants to merge 4 commits into
Conversation
|
Hi @alrzazz, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
There was a problem hiding this comment.
Pull request overview
This PR extends Envoy’s redis_proxy network filter command allowlist to recognize Redis hash field expiration commands (e.g., HEXPIRE and related variants), and updates tests/docs/release notes accordingly.
Changes:
- Added hash-field-expiration commands to the Redis proxy supported command sets (and write-command classification where applicable).
- Added a unit test covering a successful
HEXPIRErequest path and its per-command stats. - Updated Redis protocol documentation and
current.yamlrelease notes to reflect the new command support.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/extensions/filters/network/redis_proxy/command_splitter_impl_test.cc | Adds a HEXPIRE success test validating per-command stats/histogram behavior. |
| source/extensions/filters/network/common/redis/supported_commands.h | Adds HEXPIRE-family commands to supported command sets and write-command classification. |
| docs/root/intro/arch_overview/other_protocols/redis.rst | Documents the newly supported hash-field-expiration commands in the supported-command table. |
| changelogs/current.yaml | Adds a release note entry describing the new Redis command support. |
|
/gemini review |
|
Please fix DCO |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Redis 7.4 hash field expiration commands, including HEXPIRE, HEXPIREAT, HPERSIST, HPEXPIRE, HPEXPIREAT, HPTTL, and HTTL, within the redis_proxy network filter. The changes encompass command registration, documentation updates, and comprehensive unit tests for command classification and execution. Feedback from the review suggests including HEXPIRETIME and HPEXPIRETIME for completeness across the supported commands list, documentation, and test suites.
|
/wait |
hi |
Signed-off-by: Alireza <alrzazz98@gmail.com>
…lter Signed-off-by: Alireza <alrzazz98@gmail.com>
…PERSIST, HTTL, and HPTTL commands Signed-off-by: Alireza <alrzazz98@gmail.com>
Signed-off-by: Alireza <alrzazz98@gmail.com>
|
Apologies for all the mentions. I’ve restored the commits and added everything required for this pull request. If the history or changes feel too messy, I can recreate the PR from scratch to keep things cleaner and easier to review. |
Commit Message:
redis_proxy: Add support for HEXPIRE and related commands in Redis filter