Set ext_authz coverage threshold to 98%#44923
Draft
etruong42 wants to merge 7 commits into
Draft
Conversation
| Component / File | Baseline Coverage (Before) | New Coverage (After) | Improvement | | - | - | - | - | | HTTP Filter (ext_authz.cc) | 95.4% (1045/1095 lines) | 98.7% (1081/1095 lines) | +3.3% | | Network Filter (ext_authz.cc) | 89.5% (111/124 lines) | 91.1% (113/124 lines)* | +1.6% | | HTTP Common Client (ext_authz_http_impl.cc) | 96.4% (322/334 lines) | 97.9% (327/334 lines)* | +1.5% | Signed-off-by: Ethan Truong <ethantruong@google.com>
| Component / File | Baseline Coverage (Before) | New Coverage (After) | | - | - | - | | HTTP Filter (ext_authz.cc) | 95.4% (1045/1095 lines) | 99.2% (1086/1095 lines) | | HTTP Common Client (ext_authz_http_impl.cc) | 96.4% (322/334 lines) | 100.0% (334/334 lines) | Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
Member
|
let's don't set it to 100%. This will make future PR Authors' life harder:) A high and good coverage is sufficient |
Signed-off-by: Ethan Truong <ethantruong@google.com>
etruong42
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100% coverage is achieved for
A 98% coverage threshold is configured for these directories
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]