config: introduce GrpcMuxCache component & tests#45071
Draft
antoniovleonti wants to merge 3 commits into
Draft
Conversation
Signed-off-by: antoniovleonti <leonti@google.com>
Signed-off-by: antoniovleonti <leonti@google.com>
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a GrpcMuxCache utility to manage and reuse GrpcMux instances via a weak_ptr cache, alongside associated unit tests. The reviewer identified a style violation in the GrpcMuxKey class regarding public member naming conventions. Additionally, concerns were raised about the inclusion of type_url in the cache key potentially hindering mux sharing for Aggregated Discovery Services (ADS), and the lack of a pruning mechanism for expired entries in the cache map which could lead to memory growth.
Signed-off-by: antoniovleonti <leonti@google.com>
Contributor
Author
|
/assign @adisuissa |
Contributor
Author
|
/retest |
antoniovleonti
changed the title
Contributor
Author
|
per our offline discussion I need to take another look at this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: config: introduce GrpcMuxCache component & tests
Additional Description:
This pr adds a temporarily unused GrpcMuxCache so that we can reuse GrpcMuxes iff they have the exact same config source & type url.
Risk Level: none, adding unused standalone library
Testing: unit tests added
Docs Changes: none needed
Release Notes: none
Platform Specific Features: none
I used generative AI to help create this change