dynamic modules: refactor existing go sdk shared api to prep for expansion#45163
Merged
Conversation
Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
Contributor
Author
AdamEAnderson
requested review from
agrawroh,
mathetake,
mattklein123 and
wbpcode
as code owners
wbpcode
approved these changes
May 20, 2026
wbpcode
reviewed
May 20, 2026
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
The CI not works as expected. Could you merge main to kick it again? Thanks.
…-sdk-api-refactor Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dynamic modules: refactor existing go sdk to prep for expansion
Additional Description: getting ready to expand Go dynamic modules SDK to match the full ABI. This PR does some refactoring of the API code to split it into files that are http-related or cross-surface and to standardize on Godoc comments.
Previously the http api used javadoc (i.e.
@param,@returns) which isn't consistent with Golang expectations. The network filter api used Godoc as expected. Updated the Javadoc comments to conform to expectations.Otherwise no changes to the api itself, just splitting up the files differently and changing the comment formatting.
See #44910 for more details related to abi changes.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a