upstream: drop stats from original upstream clusters missing zone#45215
Open
mpoegel wants to merge 2 commits into
Open
upstream: drop stats from original upstream clusters missing zone#45215mpoegel wants to merge 2 commits into
mpoegel wants to merge 2 commits into
Conversation
Signed-off-by: Matt Poegel <mpoegel@bloomberg.net>
Signed-off-by: Matt Poegel <mpoegel@bloomberg.net>
|
Hi @mpoegel, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: drop stats from original upstream clusters missing zone
Additional Description: Original destination and dynamic forward proxy clusters create hosts with empty locality zones, producing stats with double dots (e.g.,
cluster.foo.zone.bar..upstream_rq_200).StatNameDynamicStorage("")produces a non-emptyStatNamethat bypasses the empty zone guard incodes.cc, unlikeStatNameStorage("")which correctly produces an empty one.This PR fixes
localityZoneStatName()to return a truly emptyStatNamewhen the locality zone is empty. This then matches what I believe is the intended logic incodes.ccto skip stats that are missing either zone.Risk Level: Low
Testing: Added a new unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]