tests: disable by-name extension lookup in integration tests#45216
Open
kyessenov wants to merge 5 commits into
Open
tests: disable by-name extension lookup in integration tests#45216kyessenov wants to merge 5 commits into
kyessenov wants to merge 5 commits into
Conversation
Change-Id: I225752d6a0ed55e66b6b71d111769777a25db327 Signed-off-by: Kuat Yessenov <kuat@google.com>
Change-Id: If1826b9669095db8dac4946ee82b5ab69814d4e3 Signed-off-by: Kuat Yessenov <kuat@google.com>
Change-Id: I63904bdf9dd7543c2a8e9fcf4e8edb52f5d795e7 Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov
requested review from
KBaichoo,
RyanTheOptimist,
adisuissa,
agrawroh,
mattklein123,
nezdolik,
ravenblackx,
tyxia,
wbpcode and
yanavlasov
as code owners
Contributor
Author
|
/gemini review |
kyessenov
requested review from
abeyad,
danzh2010,
ggreenway and
yanjunxiang-google
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors Envoy's integration tests to replace generic configuration types like google.protobuf.Struct with specific, test-only proto messages. It introduces numerous new proto definitions across the test suite and updates filter factories to use the UniqueEmptyHttpFilterConfig template, ensuring that test filters are correctly identified by their type URLs rather than just their names. This change also allows for the removal of the runtime override that previously permitted extension lookup by name in integration tests. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Further fixes to #23598.
Additional Description: AI disclosure: this is mostly written by AI, but I take full accountability for these changes.
Risk Level: low, test-only
Testing: yes
Docs Changes: none
Release Notes: none