Add RFC 9440 Client-Cert forwarding filter#45412
Open
somiljain2006 wants to merge 3 commits into
Open
Conversation
|
Hi @somiljain2006, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
somiljain2006
had a problem deploying
to
external-contributors
GitHub Actions
Error
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
somiljain2006
force-pushed
the
RFC-9440-support
branch
from
8fe0010 to
843d590
Compare
somiljain2006
requested a deployment
to
external-contributors
GitHub Actions
Waiting
Author
|
@wbpcode Can you review this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add RFC 9440 Client-Cert forwarding filter
Fixes #45354
Additional Description: Add an HTTP filter that emits RFC 9440 Client-Cert and Client-Cert-Chain headers from downstream mTLS client certificates. The filter sanitizes incoming Client-Cert and Client-Cert-Chain headers before forwarding and injects RFC 8941 structured-field byte sequences derived from the peer certificate and certificate chain.
Risk Level: Medium
Testing: Added unit tests covering header sanitization, non-TLS connections, empty certificates, and certificate chain handling. Added an integration test exercising RFC 9440 certificate encoding using real multi-certificate TLS chains to verify end-to-end certificate parsing and header generation.
Docs Changes: Added rfc9440_client_cert_filter.rst
Release Notes: N/A
Platform Specific Features: N/A