stats: (NON-SCOPE-BASED APPROACH)prevent unused counters from leaking across hot restart#6783
Closed
fredlas wants to merge 4 commits intoenvoyproxy:masterfrom
Closed
stats: (NON-SCOPE-BASED APPROACH)prevent unused counters from leaking across hot restart#6783fredlas wants to merge 4 commits intoenvoyproxy:masterfrom
fredlas wants to merge 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
fredlas
changed the title
Contributor
Author
|
See #6850 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold imported-from-hot-restart deltas of counters that do not yet exist in the child, until the counter is created by the child. If hot restart completes without the counter being created, the delta is forgotten about.
Risk Level: low
Testing: updated unit test
Fixes #6756.