security: policy that allows end users on the distribution list#9116
Merged
mattklein123 merged 9 commits intomasterfrom Dec 4, 2019
Merged
security: policy that allows end users on the distribution list#9116mattklein123 merged 9 commits intomasterfrom
mattklein123 merged 9 commits intomasterfrom
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@envoyproxy/security-team PTAL |
htuch
suggested changes
Nov 23, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks for putting this together. I'm largely in agreement on the broad strokes, I've opened up some threads with debatables below.
/wait
…date Signed-off-by: Matt Klein <mklein@lyft.com>
zuercher
reviewed
Dec 2, 2019
htuch
reviewed
Dec 2, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Generally LGTM modulo remaining threads.
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@envoyproxy/security-team updated PTAL |
junr03
reviewed
Dec 2, 2019
Member
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
a couple suggestions, otherwise lgtm
Signed-off-by: Matt Klein <mklein@lyft.com>
yanavlasov
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.