[WIP] examples: Add http-filter-cc using bzlmod #1041
Conversation
phlax
force-pushed
the
example-http-filter-cc
branch
19 times, most recently
from
81b7d03 to
e1a1fd4
Compare
phlax
changed the title
| namespace Envoy { | ||
| namespace Http { | ||
|
|
||
| class HttpSampleDecoderFilterConfig { |
There was a problem hiding this comment.
If the purpose is to act as an example, I would split FilterConfig out into a separate .h and .cc file (this isn't common in other filter implementations, but it is clearer and makes pieces easier to find - I think the main reason it isn't common is that everyone is cargo-cult-copying from existing examples), and put everything in a namespace more similar to the namespaces other HTTP filters do. (Envoy / Extensions / HttpFilters / Sample)
| namespace Server { | ||
| namespace Configuration { |
There was a problem hiding this comment.
This should be the same namespace as the rest of the filter, and just do using Server::Configuration::NamedHttpFilterConfigFactory etc.
But also, don't use NamedHttpFilterConfigFactory, use Extensions::HttpFilters::Common::DualFactoryBase, and override createFilterFactoryFromProtoTyped and createRouteSpecificFilterConfigTyped, and use resolveMostSpecificPerFilterConfig in the filter, to provide a really good example. Maybe also register a factory for running the filter as an upstream filter.
| } | ||
| }; | ||
|
|
||
| static Registry::RegisterFactory<HttpSampleDecoderFilterConfigFactory, NamedHttpFilterConfigFactory> |
There was a problem hiding this comment.
I think the preferred form for this is
REGISTER_FACTORY(HttpSampleDecoderFilterConfigFactory, Server::Configuration::NamedHttpFilterConfigFactory);
(Even if you're using DualFactoryBase it's still NamedHttpFilterConfigFactory)
phlax
force-pushed
the
example-http-filter-cc
branch
from
e1a1fd4 to
263c82d
Compare
phlax
force-pushed
the
example-http-filter-cc
branch
from
263c82d to
e466dad
Compare
phlax
force-pushed
the
example-http-filter-cc
branch
from
e466dad to
e3eba93
Compare
phlax
force-pushed
the
example-http-filter-cc
branch
4 times, most recently
from
23edfa9 to
5367dbb
Compare
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
phlax
force-pushed
the
example-http-filter-cc
branch
8 times, most recently
from
be6ccdb to
9a2a4f9
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
example-http-filter-cc
branch
from
9a2a4f9 to
d39e010
Compare
2 participants
No description provided.