Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

fix single-page-app CI failure: exclude node_modules/dist from verify copy

@mmorel-35 mmorel-35 marked this pull request as draft November 24, 2025 19:30
@mmorel-35 mmorel-35 force-pushed the single-page-app branch 3 times, most recently from 66ca7c8 to 9621ff5 Compare November 24, 2025 19:42
@mmorel-35 mmorel-35 changed the title fix single-page-app CI failure: exclude node_modules/dist from verify copy fix single-page-app CI failure Nov 24, 2025
@phlax
Copy link
Member

phlax commented Nov 24, 2025

where is it failing?

@mmorel-35
Copy link
Contributor Author

It's with single-page-app, no space left on device, I thought it was about dist and node_modules first but adjusting it in single-page-app/single-page-app/verify.sh#L209 or examples.bzl doesn't seems to help

@phlax
Copy link
Member

phlax commented Nov 24, 2025

no space left on device

in ci? the solution is bind mounts if so

@phlax
Copy link
Member

phlax commented Nov 24, 2025

…files to prevent CI disk exhaustion

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review November 27, 2025 19:54
@mmorel-35
Copy link
Contributor Author

The bind mounts worked

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@phlax phlax merged commit 26c3610 into envoyproxy:main Nov 27, 2025
5 checks passed
@mmorel-35 mmorel-35 deleted the single-page-app branch November 27, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants