Downstream Concurrent Connection Limit (oversight?)

[Vexali0n]

Hello,
what is the difference between setting up connection limit via CTP and directly via envoyproxy bootstrap please?

Based on the docs I would assume that if I dont specify connectlionLimit inside CTP it should be unlimited and only constraint should be cpu/ram.

However envoy gateway is hardcoding max_active_downstream_connections: 50000 what basically means one dataplane cannot accept more than this unless I change it via envoyproxy bootstrap JSONPatch.

Here is link to CTP connectionLimit:
https://gateway.envoyproxy.io/docs/api/extension_types/#connectionlimit

Here is link to the source code where 50000 is hardcoded:

gateway/internal/xds/bootstrap/bootstrap.yaml.tpl

Line 330 in be39693

max_active_downstream_connections: 50000

EnvoyGateway version used: 1.8.0

[jensrbx]

Afaik Overload Manager is across all listeners and CTP is per listener.

Does seem like an oversight that the value in the proxy bootstrap is hardcoded. It's currently set to the value in the Envoy edge best practices doc, but it'd be nice if it was a function of the CTP value (if defined).

If you want to override the 50k default, you can supply a patch via an envoy proxy CR

  bootstrap:
    type: JSONPatch
    jsonPatches:
      - op: replace
        path: /overload_manager/resource_monitors/0/typed_config/max_active_downstream_connections
        value: 1000000

[Vexali0n]

Yes that is exactly what I am doing to change the limit but I havent seen no mention about it in envoy gateway docs so I was not aware of it until I dumped configs of the dataplane.

Would be nice to have it explicitly mentioned in docs rather than searching through source code otherwise CTP connection limit suggests that it is unlimited unless you set the limit in CTP.