-
Notifications
You must be signed in to change notification settings - Fork 660
feat: set warning status for deprecated fields #7797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
56741e7 to
790bb0c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7797 +/- ##
==========================================
+ Coverage 72.72% 72.78% +0.06%
==========================================
Files 235 235
Lines 35100 35165 +65
==========================================
+ Hits 25526 25595 +69
+ Misses 7757 7754 -3
+ Partials 1817 1816 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
790bb0c to
c91527d
Compare
|
@jukie thanks for pointing that out, I was in the middle of a refactor, didn't give it a good look. Can you review this now? |
4298f48 to
1b5902e
Compare
|
/retest |
|
thanks for picking this one up, this should make it much easier to get users on the recommeneded path, added minor comments |
1b5902e to
634bc2b
Compare
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
9c4f79f to
e9ea3b8
Compare
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Matt Miller <millermatt@outlook.com>
What type of PR is this?
feat: set warning status for deprecated fields
What this PR does / why we need it:
Introduces a warning status condition for xPolicy resources if deprecated fields are used. This will be helpful in highlighting usage of these deprecated fields and can also be used for other such issues that need to be highlighted by EG.
Which issue(s) this PR fixes:
Related #6717
Release Notes: Yes