Skip to content

Conversation

@rudrakhp
Copy link
Member

What type of PR is this?
feat: set warning status for deprecated fields

What this PR does / why we need it:
Introduces a warning status condition for xPolicy resources if deprecated fields are used. This will be helpful in highlighting usage of these deprecated fields and can also be used for other such issues that need to be highlighted by EG.

Which issue(s) this PR fixes:

Related #6717

Release Notes: Yes

@rudrakhp rudrakhp requested a review from a team as a code owner December 22, 2025 17:27
@rudrakhp rudrakhp force-pushed the deprecated_status_warning branch from 56741e7 to 790bb0c Compare December 23, 2025 04:30
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.78%. Comparing base (e7c0e34) to head (c561835).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7797      +/-   ##
==========================================
+ Coverage   72.72%   72.78%   +0.06%     
==========================================
  Files         235      235              
  Lines       35100    35165      +65     
==========================================
+ Hits        25526    25595      +69     
+ Misses       7757     7754       -3     
+ Partials     1817     1816       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jukie
jukie previously approved these changes Dec 23, 2025
Copy link
Contributor

@jukie jukie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rudrakhp
Copy link
Member Author

@jukie thanks for pointing that out, I was in the middle of a refactor, didn't give it a good look. Can you review this now?

@rudrakhp rudrakhp force-pushed the deprecated_status_warning branch 6 times, most recently from 4298f48 to 1b5902e Compare December 24, 2025 03:30
@jukie
Copy link
Contributor

jukie commented Dec 24, 2025

/retest

jukie
jukie previously approved these changes Dec 24, 2025
@rudrakhp rudrakhp requested review from a team December 24, 2025 05:25
@arkodg
Copy link
Contributor

arkodg commented Dec 27, 2025

thanks for picking this one up, this should make it much easier to get users on the recommeneded path, added minor comments

jukie
jukie previously approved these changes Dec 27, 2025
@rudrakhp rudrakhp requested a review from arkodg December 28, 2025 05:42
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
@rudrakhp rudrakhp force-pushed the deprecated_status_warning branch from 9c4f79f to e9ea3b8 Compare December 29, 2025 12:23
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
@rudrakhp rudrakhp merged commit dd2861f into envoyproxy:main Jan 2, 2026
73 of 78 checks passed
millermatt pushed a commit to millermatt/envoy-gateway that referenced this pull request Jan 4, 2026
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Matt Miller <millermatt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants