-
Notifications
You must be signed in to change notification settings - Fork 660
feat: allow updating initial_fetch_timeout in bootstrap #7962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: andrei <andrei@n2.games>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
|
please add a release notes. |
Signed-off-by: andrei <andrei@n2.games>
|
@andreik-n2 please fix the conflict. |
Signed-off-by: andreik-n2 <144345749+andreik-n2@users.noreply.github.com>
|
@andreik-n2 can we default to 0 ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7962 +/- ##
==========================================
+ Coverage 73.69% 73.71% +0.02%
==========================================
Files 237 237
Lines 35653 35654 +1
==========================================
+ Hits 26274 26282 +8
+ Misses 7520 7515 -5
+ Partials 1859 1857 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't think this PR change the default value from 15s to 0s, it make it patched. |
Hi @arkodg , are you sure you want set default to 0? I read that it could lead to having envoy proxy in not ready state indefinitely. Is it something you considered? |
yeah its better to fail hard for this case that configure partial config |
|
ptal @envoyproxy/gateway-maintainers |
…guration. Signed-off-by: andrei <andrei@n2.games>
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
What type of PR is this?
fix: ignore initial_fetch_timeout in bootstrap validation to allow modifying this parameter. Set initial_fetch_timeout to 0s by default.
What this PR does / why we need it: This PR updates the bootstrap validation logic to ignore the initial_fetch_timeout field within cds_config and lds_config during comparison. Also this PR sets default initial_fetch_timeout to 0s in the bootstrap config.
Which issue(s) this PR fixes:
Fixes #5574
Release Notes: Yes