Skip to content

chore: fix flaky retry test#8020

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:fix-retry
Feb 10, 2026
Merged

chore: fix flaky retry test#8020
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:fix-retry

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jan 22, 2026

error logs:

=== RUN   TestE2E/Retry/retry-on-500
    helpers.go:627: 2026-01-22T03:55:41.477029637Z: Conditions matched expectations
    helpers.go:627: 2026-01-22T03:55:41.477087956Z: Route gateway-conformance-infra/retry-route Parents matched expectations
    retry.go:64: 2026-01-22T03:55:41.481949432Z: query count envoy_cluster_upstream_rq_retry{envoy_cluster_name="httproute/gateway-conformance-infra/retry-route/rule/0"} before: 0
    retry.go:66: 2026-01-22T03:55:41.481994556Z: Making GET request to host  via http://[fc00:f853:ccd:e793::cb]/status/500
    roundtripper.go:234: 2026-01-22T03:55:41.482118367Z: Sending Request:
        < GET /status/500 HTTP/1.1
        < Host: [fc00:f853:ccd:e793::cb]
        < User-Agent: Go-http-client/1.1
        < X-Echo-Set-Header: 
        < Accept-Encoding: gzip
        < 
        < 
        
        
    roundtripper.go:262: 2026-01-22T03:55:41.482866824Z: Received Response:
        < HTTP/1.1 503 Service Unavailable
        < Connection: close
        < Date: Thu, 22 Jan 2026 03:55:41 GMT
        < Content-Length: 0
        < 
        < 
        
        
    retry.go:73: failed to compare request and response: expected status code to be one of [500], got 503. CRes: &{503 0 HTTP/1.1 map[Content-Length:[0] Date:[Thu, 22 Jan 2026 03:55:41 GMT]] <nil> []}
    http.go:257: 2026-01-22T03:56:11.483864371Z: timeout while waiting after 30 attempts, 0/0 successes

@zirain zirain requested a review from a team as a code owner January 22, 2026 05:01
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 22, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 6e9fdeb
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6977172357f40700083567ee
😎 Deploy Preview https://deploy-preview-8020--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.75%. Comparing base (fa32a93) to head (6e9fdeb).
⚠️ Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8020      +/-   ##
==========================================
+ Coverage   73.70%   73.75%   +0.05%     
==========================================
  Files         237      237              
  Lines       35703    35703              
==========================================
+ Hits        26314    26333      +19     
+ Misses       7529     7514      -15     
+ Partials     1860     1856       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- matches:
- path:
type: PathPrefix
value: /status
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does moving from /status to / fix this ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// we can not use /status/200 here because the response is empty and
// failed to pass the "eventually consistent" check

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please elaborate

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k exec -it deployments/sleep -- curl backend:3000/
{
 "path": "/",
 "host": "backend:3000",
 "method": "GET",
 "proto": "HTTP/1.1",
 "headers": {
  "Accept": [
   "*/*"
  ],
  "User-Agent": [
   "curl/8.16.0"
  ]
 },
 "namespace": "default",
 "ingress": "",
 "service": "",
 "pod": "backend-869c8646c5-c7rzg"
}%
❯ k exec -it deployments/sleep -- curl backend:3000/status/2000

the function expected a JOSN response when resposne code is 200.

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain merged commit 14062fa into envoyproxy:main Feb 10, 2026
36 checks passed
@zirain zirain deleted the fix-retry branch February 10, 2026 15:07
Inode1 pushed a commit to Inode1/gateway that referenced this pull request Feb 23, 2026
* chore: fix flaky retry test

Signed-off-by: zirain <zirain2009@gmail.com>

* nit

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants