Skip to content

fix: watch TLSRoute v1#8327

Merged
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-8326
Feb 27, 2026
Merged

fix: watch TLSRoute v1#8327
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-8326

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Feb 23, 2026

fixes: #8326

This PR updates the watcher to use v1 instead of v1alpha3 to avoid breaking the Gateway API standard channel. It also removes the TLSRouteCRDExist check, since the CRD has been promoted to v1 and is no longer optional.

served: false
storage: false

@zhaohuabing zhaohuabing requested a review from a team as a code owner February 23, 2026 14:48
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 23, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 6da0925
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69a1384d91013f000844d6b2

@zhaohuabing zhaohuabing marked this pull request as draft February 23, 2026 14:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 60.41667% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.85%. Comparing base (e23be16) to head (6da0925).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 66.66% 3 Missing and 2 partials ⚠️
internal/provider/kubernetes/indexers.go 50.00% 0 Missing and 3 partials ⚠️
internal/provider/kubernetes/predicates.go 62.50% 2 Missing and 1 partial ⚠️
internal/provider/kubernetes/status.go 0.00% 3 Missing ⚠️
internal/provider/kubernetes/status_updater.go 0.00% 3 Missing ⚠️
internal/cmd/egctl/status.go 0.00% 1 Missing ⚠️
internal/provider/kubernetes/routes.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8327      +/-   ##
==========================================
+ Coverage   73.83%   73.85%   +0.01%     
==========================================
  Files         242      242              
  Lines       37064    37055       -9     
==========================================
  Hits        27367    27367              
+ Misses       7765     7759       -6     
+ Partials     1932     1929       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing marked this pull request as ready for review February 24, 2026 01:07
@zirain zirain force-pushed the fix-8326 branch 2 times, most recently from e58b0b6 to 070e6a7 Compare February 26, 2026 02:55
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing merged commit 2cd8254 into envoyproxy:main Feb 27, 2026
117 of 128 checks passed
@zhaohuabing zhaohuabing deleted the fix-8326 branch February 27, 2026 12:17
antonio-mazzini pushed a commit to antonio-mazzini/gateway that referenced this pull request Mar 5, 2026
* update TLSRoute to v1

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* make TLSRoute CRD mandatory

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLSRoute doesn't work with Gateway API standard channel

4 participants