Skip to content

fix ListenerSet conformance test#8344

Merged
zirain merged 6 commits intoenvoyproxy:mainfrom
zirain:listenerset
Feb 27, 2026
Merged

fix ListenerSet conformance test#8344
zirain merged 6 commits intoenvoyproxy:mainfrom
zirain:listenerset

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Feb 25, 2026

  • remove prefix x from filename
  • enable ListenerSet conformance test

TODO: revist ListenerSetHostnameConflict and ListenerSetProtocolConflict later

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner February 25, 2026 08:22
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 25, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 56260ee
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/699ec52a92f1b2000893450e

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.72%. Comparing base (26fa4e6) to head (56260ee).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/status/listenerset.go 71.42% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8344      +/-   ##
==========================================
- Coverage   73.73%   73.72%   -0.01%     
==========================================
  Files         241      241              
  Lines       37077    37097      +20     
==========================================
+ Hits        27337    27349      +12     
- Misses       7796     7804       +8     
  Partials     1944     1944              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain merged commit ed18c9c into envoyproxy:main Feb 27, 2026
159 of 174 checks passed
@zirain zirain deleted the listenerset branch February 27, 2026 02:36
antonio-mazzini pushed a commit to antonio-mazzini/gateway that referenced this pull request Mar 5, 2026
* rename

Signed-off-by: zirain <zirain2009@gmail.com>

* fix ListenerSetAllowedNamespaceSame

Signed-off-by: zirain <zirain2009@gmail.com>

* fix ListenerSetReferenceGrant

Signed-off-by: zirain <zirain2009@gmail.com>

* update

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

* fix e2e

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants