api: Add source type structure for dynamic modules#8359
Merged
jukie merged 7 commits intoenvoyproxy:mainfrom Mar 5, 2026
Merged
api: Add source type structure for dynamic modules#8359jukie merged 7 commits intoenvoyproxy:mainfrom
jukie merged 7 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8359 +/- ##
==========================================
- Coverage 74.23% 74.19% -0.04%
==========================================
Files 242 242
Lines 37322 37334 +12
==========================================
- Hits 27705 27700 -5
- Misses 7686 7700 +14
- Partials 1931 1934 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
jukie
force-pushed
the
dynamic-module-source-rework
branch
from
8617415 to
6113fff
Compare
jukie
commented
Feb 27, 2026
internal/gatewayapi/testdata/envoyextensionpolicy-with-dynamicmodule.in.yaml
Show resolved
Hide resolved
jukie
commented
Feb 27, 2026
internal/gatewayapi/testdata/envoyextensionpolicy-with-invalid-dynamicmodule.in.yaml
Outdated
Show resolved
Hide resolved
jukie
changed the title
Contributor
Author
|
/retest |
jukie
changed the title
Contributor
Author
|
/retest |
arkodg
reviewed
Mar 1, 2026
| // +optional | ||
| Local *LocalDynamicModuleSource `json:"local,omitempty"` | ||
|
|
||
| // Remote specifies a module fetched from a remote source. |
Contributor
There was a problem hiding this comment.
can we rm this, since it doesnt exist it
Contributor
Author
There was a problem hiding this comment.
I saw you approved but assume you still want this removed before merging?
Contributor
Author
There was a problem hiding this comment.
Updated now that envoyproxy/envoy#43333 is merged but still left this in.
I'm going to adjust this again, might as well drop the LibraryName path and use asyncDatasource for all.
arkodg
reviewed
Mar 1, 2026
arkodg
reviewed
Mar 2, 2026
arkodg
previously approved these changes
Mar 2, 2026
zhaohuabing
previously approved these changes
Mar 2, 2026
jukie
force-pushed
the
dynamic-module-source-rework
branch
from
3c5e688 to
93a2944
Compare
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
zhaohuabing
reviewed
Mar 5, 2026
zhaohuabing
reviewed
Mar 5, 2026
zhaohuabing
previously approved these changes
Mar 5, 2026
zirain
previously approved these changes
Mar 5, 2026
jukie
force-pushed
the
dynamic-module-source-rework
branch
from
3951769 to
ec13f74
Compare
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Contributor
Author
|
/retest |
zhaohuabing
approved these changes
Mar 5, 2026
Contributor
Author
|
/retest |
zirain
approved these changes
Mar 5, 2026
antonio-mazzini
pushed a commit
to antonio-mazzini/gateway
that referenced
this pull request
Mar 5, 2026
* Add API surface for multiple source types Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> * lint Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> * updates Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> * only use async Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> * fix e2e Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> * rename modulePath Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> --------- Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote fetching will be a future option (ref envoyproxy/envoy#43333) so adding an API surface to expose different source types