feat: upstream access log#8397
Merged
zirain merged 8 commits intoenvoyproxy:mainfrom Mar 23, 2026
Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8397 +/- ##
==========================================
- Coverage 74.14% 74.14% -0.01%
==========================================
Files 242 242
Lines 37669 37764 +95
==========================================
+ Hits 27929 27999 +70
- Misses 7783 7810 +27
+ Partials 1957 1955 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
force-pushed
the
upstream-access-log
branch
2 times, most recently
from
24f8bbd to
3999388
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
upstream-access-log
branch
from
3999388 to
8f06944
Compare
zhaohuabing
reviewed
Mar 19, 2026
zhaohuabing
reviewed
Mar 19, 2026
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
upstream-access-log
branch
from
6389e48 to
5a740f5
Compare
arkodg
reviewed
Mar 23, 2026
| ProxyAccessLogTypeRoute ProxyAccessLogType = "Route" | ||
|
|
||
| // ProxyAccessLogTypeUpstream defines the accesslog for upstream. | ||
| ProxyAccessLogTypeUpstream ProxyAccessLogType = "Upstream" |
Contributor
There was a problem hiding this comment.
thoughts on calling this Backend to map closer to EG / Gateway API terminology or Upstream to map closer to Envoy Proxy terminology ?
Member
Author
There was a problem hiding this comment.
Backend is tied to Backend API or BackendRef or BackendTrafficPolicy
since its the EnvoyProxy API, so more envoy proxy native nouns are okay here
arkodg
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #7780