feat: support invert in source match#8407
Merged
rudrakhp merged 1 commit intoenvoyproxy:mainfrom Mar 30, 2026
Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8407 +/- ##
==========================================
+ Coverage 74.33% 74.35% +0.01%
==========================================
Files 243 243
Lines 38155 38164 +9
==========================================
+ Hits 28364 28377 +13
+ Misses 7802 7801 -1
+ Partials 1989 1986 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edcb51b to
0581fdc
Compare
0581fdc to
039f88c
Compare
039f88c to
cf12bb7
Compare
cf12bb7 to
30aca46
Compare
kkk777-7
previously approved these changes
Mar 26, 2026
Member
|
thanks, Overall LGTM! |
zhaohuabing
reviewed
Mar 27, 2026
30aca46 to
2b0c630
Compare
zhaohuabing
reviewed
Mar 30, 2026
internal/xds/translator/testdata/out/ratelimit-config/masked-remote-address-match.routes.yaml
Show resolved
Hide resolved
zhaohuabing
reviewed
Mar 30, 2026
internal/xds/translator/testdata/out/ratelimit-config/masked-remote-address-match.routes.yaml
Show resolved
Hide resolved
zhaohuabing
reviewed
Mar 30, 2026
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
2b0c630 to
2ebeb85
Compare
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: support invert in source match
What this PR does / why we need it:
This PR is needed to support usecases that need invert SourceMatch. For example rate limit all IPs except those matching a CIDR. To do this following changes were made:
RemoteAddressMatchrate limit action fromMaskedRemoteAddressandRemoteAddressactions.AddressMatcherhas an flag to invert matches that allows to define a white list to not apply rate limits on.Which issue(s) this PR fixes:
Fixes #4385
Related Envoy PRs: envoyproxy/envoy#42845 envoyproxy/envoy#43320
Reviewer notes:
InvertunderSourceMatch.ratelimit.goandlocal_ratelimit.go.Release Notes: Yes