feat: GeoIP#8453
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8453 +/- ##
==========================================
- Coverage 74.35% 74.30% -0.05%
==========================================
Files 242 243 +1
Lines 37811 38143 +332
==========================================
+ Hits 28113 28344 +231
- Misses 7748 7809 +61
- Partials 1950 1990 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7ca9aa7 to
7c55f37
Compare
eda5889 to
3b5d9d0
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> GeoIP implementation Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
rudrakhp
left a comment
There was a problem hiding this comment.
Some questions and minor comments
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
|
Hello @zhaohuabing , quick question regarding logging here before I file it as an issue. I was trying this out ahead of the apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
name: default-gateway-proxy-config
namespace: envoy-gateway-system
spec:
...
telemetry:
accessLog:
settings:
- format:
type: JSON
json:
...
geo_country_code: "%REQ(X-EG-INTERNAL-GEOIP-COUNTRY)%"
---
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: SecurityPolicy
metadata:
name: geo-ip-protection
namespace: envoy-gateway-system
spec:
targetRefs: [
...
]
authorization:
defaultAction: Allow
rules:
- action: Deny
principal:
clientIPGeoLocations:
- country: USThe rejection works fine, but I only see the Side question; is there a reason why we would add It would be great if we also add |
Implements: #4412 #8002