e2e: ratelimit test not rely on the count of request

[zirain]

fixes: #8360 #8419

[netlify]

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	4afa7ec
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69b345fc05aae400086d7a7e
😎 Deploy Preview	https://deploy-preview-8472--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.12%. Comparing base (a470576) to head (4afa7ec).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8472      +/-   ##
==========================================
- Coverage   74.13%   74.12%   -0.02%     
==========================================
  Files         242      242              
  Lines       37579    37603      +24     
==========================================
+ Hits        27859    27873      +14     
- Misses       7778     7785       +7     
- Partials     1942     1945       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rudrakhp]

Is it a proper E2E without checking request count? If we expect rate limit config to work and just expect it to be there in the proxy, why not simply verify existence of rate limit header? So only MakeRequestAndExpectEventuallyConsistentResponseExceptErrors call is sufficient?

[zirain]

Is it a proper E2E without checking request count? If we expect rate limit config to work and just expect it to be there in the proxy, why not simply verify existence of rate limit header? So only MakeRequestAndExpectEventuallyConsistentResponseExceptErrors call is sufficient?

expectOkResp.Response.Headers["X-Ratelimit-Limit"] = "3, 3;w=3600" make sure that the ratelimit service return the correct ratelimit setting, then check 429 response code to make sure that rate limit happen in real.

[rudrakhp]

I guess its better to check 429 behavior, but I am still not sure if disregarding count for rate limit tests will be fine for a proper e2e. I am ok with having this before we have a better solution.
@envoyproxy/gateway-maintainers wdyt?