Skip to content

e2e: fix ConnectionLimit test#8473

Merged
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zirain:fix/ConnectionLimit
Mar 18, 2026
Merged

e2e: fix ConnectionLimit test#8473
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zirain:fix/ConnectionLimit

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Mar 10, 2026

fixes: #8456

Don't use t.Errorf which will mark the test as failed.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner March 10, 2026 06:13
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 10, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit f85d709
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69afb67acef73a000852cd43

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.11%. Comparing base (a470576) to head (f85d709).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8473      +/-   ##
==========================================
- Coverage   74.13%   74.11%   -0.02%     
==========================================
  Files         242      242              
  Lines       37579    37579              
==========================================
- Hits        27859    27853       -6     
- Misses       7778     7783       +5     
- Partials     1942     1943       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg arkodg requested review from a team March 15, 2026 01:46
@zhaohuabing zhaohuabing merged commit a07ce1e into envoyproxy:main Mar 18, 2026
99 of 105 checks passed
@zirain zirain deleted the fix/ConnectionLimit branch March 18, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAIL: TestE2E/ConnectionLimit

3 participants