ci: fix ACTIONS_STEP_DEBUG not working

[zirain]

xref: https://docs.github.com/en/actions/how-tos/monitor-workflows/enable-debug-logging?search-overlay-input=jobs#enabling-step-debug-logging

You can also use the runner.debug context to conditionally run steps only when debug logging is enabled. For more information

set ACTIONS_STEP_DEBUG env if runner.debug is 1

[netlify]

✅ Deploy Preview for cerulean-figolla-1f9435 canceled.

Name	Link
🔨 Latest commit	78b84f6
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69ba53a4f27134000801243f

[zhaohuabing]

Hi @zirain do you have a chance to test this works when manually run a flow with enable debugging is checked?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.14%. Comparing base (db1c3ce) to head (78b84f6).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8517      +/-   ##
==========================================
- Coverage   74.17%   74.14%   -0.04%     
==========================================
  Files         242      242              
  Lines       37609    37669      +60     
==========================================
+ Hits        27895    27928      +33     
- Misses       7773     7787      +14     
- Partials     1941     1954      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[zirain]

Hi @zirain do you have a chance to test this works when manually run a flow with enable debugging is checked?

before: https://github.com/envoyproxy/gateway/actions/runs/23038429771/job/66912666163
after: https://github.com/envoyproxy/gateway/actions/runs/23038429771/job/66919086755

[arkodg]

how is ACTIONS_STEP_DEBUG related to ENABLE_COLLECT_AND_DUMP

[zirain]

how is ACTIONS_STEP_DEBUG related to ENABLE_COLLECT_AND_DUMP

'ACTIONS_STEP_DEBUG' is used to manually open the debug log of github CI and rename it to 'ENABLE_COLLECT_AND_DUMP' to avoid misunderstanding.

[zirain]

@arkodg @zhaohuabing I simply this change, just set ACTIONS_STEP_DEBUG when runner.debug is 1.

[zhaohuabing]

Do we need to rename ACTIONS_STEP_DEBUG to ENABLE_COLLECT_AND_DUMP in test/e2e/tests/utils.go?

[zirain]

Do we need to rename ACTIONS_STEP_DEBUG to ENABLE_COLLECT_AND_DUMP in test/e2e/tests/utils.go?

we could do that if needed in the future.