feat: add support for contrpl plane tracer#8551
Merged
zirain merged 15 commits intoenvoyproxy:mainfrom Apr 7, 2026
Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (17.20%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8551 +/- ##
==========================================
- Coverage 74.39% 74.22% -0.18%
==========================================
Files 243 244 +1
Lines 38345 38429 +84
==========================================
- Hits 28526 28523 -3
- Misses 7821 7903 +82
- Partials 1998 2003 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stekole
reviewed
Mar 19, 2026
stekole
reviewed
Mar 19, 2026
zhaohuabing
reviewed
Apr 1, 2026
zhaohuabing
reviewed
Apr 1, 2026
zhaohuabing
reviewed
Apr 1, 2026
zhaohuabing
reviewed
Apr 1, 2026
Signed-off-by: Shreemaan Abhishek <shreemaanabhishek@apache.org>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
reviewed
Apr 2, 2026
| // EnvoyGatewayTraces defines control plane tracing configurations. | ||
| type EnvoyGatewayTraces struct { | ||
| // Sink defines the trace sink where traces are sent to. | ||
| Sink EnvoyGatewayTraceSink `json:"sink,omitempty"` |
Contributor
There was a problem hiding this comment.
if we add list here for sinks, will implementation be able to support ?
Member
Author
There was a problem hiding this comment.
Technically speaking, it is feasible. But i'd like to leave those parts to OTel collector.
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move #7859 forward, base on @shreealt work.