Skip to content

feat: add support for contrpl plane tracer#8551

Merged
zirain merged 15 commits intoenvoyproxy:mainfrom
zirain:mp-tracer
Apr 7, 2026
Merged

feat: add support for contrpl plane tracer#8551
zirain merged 15 commits intoenvoyproxy:mainfrom
zirain:mp-tracer

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Mar 18, 2026

Move #7859 forward, base on @shreealt work.

@zirain zirain requested a review from a team as a code owner March 18, 2026 09:03
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 18, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit b28a11a
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69cdccbab6c36c00096b4d89

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 17.20430% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.22%. Comparing base (8986e16) to head (b28a11a).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
internal/traces/register.go 6.34% 59 Missing ⚠️
api/v1alpha1/validation/envoygateway_validate.go 21.73% 13 Missing and 5 partials ⚠️

❌ Your patch status has failed because the patch coverage (17.20%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8551      +/-   ##
==========================================
- Coverage   74.39%   74.22%   -0.18%     
==========================================
  Files         243      244       +1     
  Lines       38345    38429      +84     
==========================================
- Hits        28526    28523       -3     
- Misses       7821     7903      +82     
- Partials     1998     2003       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread internal/traces/register.go Outdated
Comment thread internal/traces/register.go Outdated
Comment thread api/v1alpha1/envoygateway_traces_types.go
Comment thread internal/traces/register.go Outdated
Comment thread api/v1alpha1/envoygateway_traces_types.go Outdated
Comment thread api/v1alpha1/envoygateway_traces_types.go Outdated
shreealt and others added 14 commits April 2, 2026 08:17
Signed-off-by: Shreemaan Abhishek <shreemaanabhishek@apache.org>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested review from a team and zhaohuabing April 2, 2026 00:37
arkodg
arkodg previously approved these changes Apr 2, 2026
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

// EnvoyGatewayTraces defines control plane tracing configurations.
type EnvoyGatewayTraces struct {
// Sink defines the trace sink where traces are sent to.
Sink EnvoyGatewayTraceSink `json:"sink,omitempty"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we add list here for sinks, will implementation be able to support ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking, it is feasible. But i'd like to leave those parts to OTel collector.

Signed-off-by: zirain <zirain2009@gmail.com>
@arkodg arkodg requested review from a team April 6, 2026 03:03
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zirain zirain merged commit 0e26106 into envoyproxy:main Apr 7, 2026
38 of 39 checks passed
@zirain zirain deleted the mp-tracer branch April 7, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants