Skip to content

feat: JSON log encoder uses abbreviated field keys#8555

Open
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
zirain:use-production
Open

feat: JSON log encoder uses abbreviated field keys#8555
zirain wants to merge 1 commit intoenvoyproxy:mainfrom
zirain:use-production

Conversation

@zirain
Copy link
Member

@zirain zirain commented Mar 19, 2026

fixes: #8552

the output as following:

{"level":"info","ts":1773900658.0818536,"logger":"provider","caller":"kubernetes/controller.go:1202","msg":"processing OIDC HMAC Secret","runner":"provider","namespace":"envoy-gateway-system","name":"envoy-oidc-hmac"}
{"level":"info","ts":1773900658.0818622,"logger":"provider","caller":"kubernetes/controller.go:1224","msg":"processing Envoy TLS Secret","runner":"provider","namespace":"envoy-gateway-system","name":"envoy"}
{"level":"info","ts":1773900658.0820184,"logger":"provider","caller":"kubernetes/controller.go:557","msg":"No gateways found for accepted GatewayClass","runner":"provider","trace_id":"b30673449e19b35ed56c38140f7f882e","span_id":"168c82967f8a79f9","GatewayClass":"internet"}
{"level":"info","ts":1773900658.0822415,"logger":"provider","caller":"kubernetes/controller.go:600","msg":"reconciled gateways successfully","runner":"provider","trace_id":"b30673449e19b35ed56c38140f7f882e","span_id":"168c82967f8a79f9"}

@zirain zirain requested a review from a team as a code owner March 19, 2026 06:14
@zirain zirain added this to the v1.8.0-rc.1 Release milestone Mar 19, 2026
@netlify
Copy link

netlify bot commented Mar 19, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit d092626
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69c1fd485bf7aa0008432778
😎 Deploy Preview https://deploy-preview-8555--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.35%. Comparing base (a049df2) to head (d092626).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8555   +/-   ##
=======================================
  Coverage   74.35%   74.35%           
=======================================
  Files         242      242           
  Lines       37811    37811           
=======================================
+ Hits        28113    28114    +1     
+ Misses       7748     7747    -1     
  Partials     1950     1950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg
Copy link
Contributor

arkodg commented Mar 23, 2026

is another API needed, or should this be enabled by default ?

@zirain
Copy link
Member Author

zirain commented Mar 23, 2026

is another API needed, or should this be enabled by default ?

this only reason for a new API i could image is not breaking the existing users.

@arkodg
Copy link
Contributor

arkodg commented Mar 23, 2026

imo making this opt in feels more non intuitive, wdyt @envoyproxy/gateway-maintainers

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Member Author

zirain commented Mar 24, 2026

imo making this opt in feels more non intuitive, wdyt @envoyproxy/gateway-maintainers

After review this:

  1. For Text encoder, seems nothing is changed.
  2. For JSON encoder, production encoder config is better.

So I changed to use production config by default with a breaking change notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON log encoder uses abbreviated field keys

2 participants