Skip to content

fix: reject incompatible requestBuffer + httpUpgrade CTP#8605

Merged
rudrakhp merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-8578
Mar 29, 2026
Merged

fix: reject incompatible requestBuffer + httpUpgrade CTP#8605
rudrakhp merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-8578

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Mar 27, 2026

This PR:

  • Disable the default WebSocket upgrade on a route when a BackendTrafficPolicy with requestBuffer is attached to it.
  • Reject incompatible configurations when both requestBuffer and httpUpgrade are explicitly configured.

fixes: #8578
release-note: yes

@zhaohuabing zhaohuabing requested a review from a team as a code owner March 27, 2026 07:17
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 27, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 00311b3
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69c634bae8a1a10008081677
😎 Deploy Preview https://deploy-preview-8605--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zhaohuabing zhaohuabing marked this pull request as draft March 27, 2026 07:19
@zhaohuabing zhaohuabing marked this pull request as ready for review March 27, 2026 07:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.34%. Comparing base (7bff34c) to head (00311b3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8605      +/-   ##
==========================================
+ Coverage   74.31%   74.34%   +0.02%     
==========================================
  Files         243      243              
  Lines       38147    38155       +8     
==========================================
+ Hits        28349    28366      +17     
+ Misses       7808     7800       -8     
+ Partials     1990     1989       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@rudrakhp rudrakhp changed the title fix: reject imcompatible requestBuffer + httpUpgrade CTP fix: reject incompatible requestBuffer + httpUpgrade CTP Mar 28, 2026
@rudrakhp rudrakhp requested review from a team March 28, 2026 08:16
@rudrakhp rudrakhp merged commit b1d7302 into envoyproxy:main Mar 29, 2026
80 of 85 checks passed
@zhaohuabing zhaohuabing deleted the fix-8578 branch March 30, 2026 11:51
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
…8605)

fix: reject imcompatible requestBuffer + httpUpgrade CTP

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requestBuffer in BackendTrafficPolicy breaks WebSocket upgrades (silent deadlock)

3 participants