fix(xds): preserve original host metadata for DFP rewrites#8610
fix(xds): preserve original host metadata for DFP rewrites#8610officialasishkumar wants to merge 1 commit into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
|
are you sure that this fixed the issue? |
Keep the route-level host rewrite metadata in place for dynamic forward proxy routes so Envoy can still emit the original host headers, while DFP per-route config continues to drive DNS resolution. Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
46cc646 to
f6a5cbc
Compare
|
@zirain yes |
I tested it locally, and it didn't find it worked(maybe i missed something). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8610 +/- ##
==========================================
+ Coverage 74.29% 74.32% +0.02%
==========================================
Files 243 243
Lines 38155 38150 -5
==========================================
+ Hits 28347 28354 +7
+ Misses 7815 7806 -9
+ Partials 1993 1990 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I haven’t verified this yet, but I’d expect This may require a change on the Envoy side to have the DFP filter set this header. cc @wbpcode, who has more context here. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
What type of PR is this?
fix(xds): preserve original host metadata for DFP rewrites
What this PR does / why we need it:
Dynamic forward proxy host rewrites were clearing the route-level host rewrite metadata after the per-route DFP config was added. That left Envoy without the router-level information it uses to emit
X-ENVOY-ORIGINAL-HOST, even though the rewritten host still drove DNS resolution. This change keeps the route host rewrite metadata in place, adds a focused regression test for both header and literal rewrites, and updates the translator golden output accordingly.Which issue(s) this PR fixes:
Fixes #8353
Release Notes: Yes