Skip to content

chore: fix metrics check in the rate limit e2e tests#8636

Merged
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-rate-limit-test
Apr 1, 2026
Merged

chore: fix metrics check in the rate limit e2e tests#8636
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-rate-limit-test

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

No description provided.

@zhaohuabing zhaohuabing requested a review from a team as a code owner April 1, 2026 03:03
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 1, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit ee93bbc
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69cca954dec7910008d4a990

@zhaohuabing zhaohuabing marked this pull request as draft April 1, 2026 03:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.42%. Comparing base (c86eb78) to head (ee93bbc).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8636      +/-   ##
==========================================
+ Coverage   74.38%   74.42%   +0.04%     
==========================================
  Files         243      243              
  Lines       38227    38345     +118     
==========================================
+ Hits        28436    28540     +104     
- Misses       7802     7809       +7     
- Partials     1989     1996       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing force-pushed the fix-rate-limit-test branch 2 times, most recently from ef6c8cf to c810ea9 Compare April 1, 2026 04:17
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the fix-rate-limit-test branch from c810ea9 to ee93bbc Compare April 1, 2026 05:12
@zhaohuabing
Copy link
Copy Markdown
Member Author

/retest

@zhaohuabing zhaohuabing marked this pull request as ready for review April 1, 2026 07:16
@zhaohuabing zhaohuabing requested review from rudrakhp and zirain April 1, 2026 07:16
@zhaohuabing zhaohuabing merged commit 2b265ab into envoyproxy:main Apr 1, 2026
54 of 59 checks passed
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
fix rate limit test metrics

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants