chore: remove cluster.LbPolicy usage#8637
Merged
jukie merged 4 commits intoenvoyproxy:mainfrom Apr 2, 2026
Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
jukie
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8637 +/- ##
==========================================
- Coverage 74.51% 74.48% -0.03%
==========================================
Files 243 243
Lines 38677 38670 -7
==========================================
- Hits 28819 28803 -16
- Misses 7865 7873 +8
- Partials 1993 1994 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
zirain
force-pushed
the
remove-lbpolicy-field
branch
from
1531be9 to
83bbb7f
Compare
Contributor
Author
|
/retest |
arkodg
approved these changes
Apr 2, 2026
rudrakhp
approved these changes
Apr 2, 2026
Member
|
/retest |
skos-ninja
pushed a commit
to skos-ninja/envoy-gateway
that referenced
this pull request
May 1, 2026
* Remove cluster.LbPolicy usage Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * regen after merging main Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * regen Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> * regen Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> --------- Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: jukie <10012479+jukie@users.noreply.github.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Usage of
cluster.load_balancing_policywas introduced in #5833 and is alwas configured. When this field is present it always supersedescluster.lb_policy- https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.protoWe should remove the now redundant usage of
lb_policywhich also helps reduce xds config size for each cluster.