Skip to content

fix for duplicate cidr local rate limit rules#8650

Merged
jukie merged 3 commits intoenvoyproxy:mainfrom
erik-hunter:fix-conflicting-cidr-ratelimit
Apr 2, 2026
Merged

fix for duplicate cidr local rate limit rules#8650
jukie merged 3 commits intoenvoyproxy:mainfrom
erik-hunter:fix-conflicting-cidr-ratelimit

Conversation

@erik-hunter
Copy link
Copy Markdown
Contributor

What type of PR is this?
Fix for duplicated rate limit rules.

What this PR does / why we need it:
Allow multiple local rate limit rules with CIDR matchers. Follows same pattern used for other ratelimit rules by adding index into the descriptor.

Which issue(s) this PR fixes:

Fixes #8632

Signed-off-by: Erik Hunter <5383873+erik-hunter@users.noreply.github.com>
@erik-hunter erik-hunter requested a review from a team as a code owner April 1, 2026 21:34
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 1, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 3d8c0a4
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69cde09efbc7e9000812d88f

Comment thread internal/xds/translator/local_ratelimit.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (ac18feb) to head (3d8c0a4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8650      +/-   ##
==========================================
- Coverage   74.38%   74.38%   -0.01%     
==========================================
  Files         243      243              
  Lines       38350    38356       +6     
==========================================
+ Hits        28528    28530       +2     
- Misses       7822     7827       +5     
+ Partials     2000     1999       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg arkodg requested a review from rudrakhp April 1, 2026 22:46
@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Apr 1, 2026
@arkodg arkodg requested a review from zirain April 1, 2026 22:47
@zirain
Copy link
Copy Markdown
Member

zirain commented Apr 2, 2026

@jukie need to backport?

@jukie jukie requested a review from a team April 2, 2026 04:31
@zirain zirain changed the title fix for duplicate cidr local rate limit rules (#8632) fix for duplicate cidr local rate limit rules Apr 2, 2026
@jukie jukie merged commit f1fedb1 into envoyproxy:main Apr 2, 2026
57 of 59 checks passed
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local rate limit rules with identical clientSelectors.sourceCIDR are rejected by Envoy

5 participants