fix for duplicate cidr local rate limit rules#8650
Merged
jukie merged 3 commits intoenvoyproxy:mainfrom Apr 2, 2026
Merged
Conversation
Signed-off-by: Erik Hunter <5383873+erik-hunter@users.noreply.github.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
jukie
reviewed
Apr 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8650 +/- ##
==========================================
- Coverage 74.38% 74.38% -0.01%
==========================================
Files 243 243
Lines 38350 38356 +6
==========================================
+ Hits 28528 28530 +2
- Misses 7822 7827 +5
+ Partials 2000 1999 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jukie
approved these changes
Apr 1, 2026
zirain
approved these changes
Apr 2, 2026
Member
|
@jukie need to backport? |
skos-ninja
pushed a commit
to skos-ninja/envoy-gateway
that referenced
this pull request
May 1, 2026
Signed-off-by: Jake Oliver <jake@truelayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fix for duplicated rate limit rules.
What this PR does / why we need it:
Allow multiple local rate limit rules with CIDR matchers. Follows same pattern used for other ratelimit rules by adding index into the descriptor.
Which issue(s) this PR fixes:
Fixes #8632