fix: restore failure-path metric recording for delete and HPA reconcile

[felipesabadini]

What type of PR is this?

fix

What this PR does / why we need it

Follow-up to #8480 — restores failure-path observability that regressed when
the no-op delete metric fix was introduced.

Problem: Moving the metric-recording defer blocks to after existence checks
fixed no-op metric inflation, but failures on the pre-defer paths stopped being
recorded:

• createOrUpdateHPA() returned on r.HorizontalPodAutoscaler() errors before
  the defer, so HPA render failures no longer incremented
  resource_apply_total{result="failure"}.
• deleteDeployment(), deleteDaemonSet(), deleteHPA(), and deletePDB()
  returned on the pre-delete List() call before the defer, so list/RBAC/API
  failures no longer incremented resource_delete_total{result="failure"}.

Fix: Add explicit failure metric recording on the early-return error paths,
matching the pattern already used by createOrUpdateDeployment,
createOrUpdateDaemonSet, and createOrUpdatePodDisruptionBudget.

Changes

• Add resourceApplyTotal.WithFailure(...) on the r.HorizontalPodAutoscaler()
  error path in createOrUpdateHPA()
• Add resourceDeleteTotal.WithFailure(...) on the List() error paths in
  deleteDeployment(), deleteDaemonSet(), deleteHPA(), deletePDB()
• Add TestDeleteListFailureReturnsError to verify error propagation when
  pre-delete List() calls fail

Which issue(s) this PR fixes

Fixes #8651

Release Notes

No

[netlify]

✅ Deploy Preview for cerulean-figolla-1f9435 canceled.

Name	Link
🔨 Latest commit	1569c12
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69ce4d0fe79c640008b0b693

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.44%. Comparing base (dd79a83) to head (1569c12).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ternal/infrastructure/kubernetes/infra_resource.go	80.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8656   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files         243      243           
  Lines       38350    38355    +5     
=======================================
+ Hits        28549    28553    +4     
- Misses       7804     7811    +7     
+ Partials     1997     1991    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.