Skip to content

chore: align all helm calls to use go tool#8659

Merged
jukie merged 2 commits intoenvoyproxy:mainfrom
shahar-h:use-helm-tool
Apr 2, 2026
Merged

chore: align all helm calls to use go tool#8659
jukie merged 2 commits intoenvoyproxy:mainfrom
shahar-h:use-helm-tool

Conversation

@shahar-h
Copy link
Copy Markdown
Contributor

@shahar-h shahar-h commented Apr 2, 2026

What this PR does / why we need it:

Replace bare helm commands with $(GO_TOOL) helm in helm.mk and kube.mk for consistency with the rest of the codebase. This ensures the project-pinned Helm version is used everywhere.

Which issue(s) this PR fixes:

N/A

Release Notes: No

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner April 2, 2026 17:04
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 2, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 96ee587
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69ceb409ee11ec000830a719

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.50%. Comparing base (b4b5cab) to head (96ee587).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8659      +/-   ##
==========================================
+ Coverage   74.46%   74.50%   +0.03%     
==========================================
  Files         243      243              
  Lines       38670    38670              
==========================================
+ Hits        28796    28810      +14     
+ Misses       7879     7867      -12     
+ Partials     1995     1993       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahar-h
Copy link
Copy Markdown
Contributor Author

shahar-h commented Apr 2, 2026

/retest

@shahar-h
Copy link
Copy Markdown
Contributor Author

shahar-h commented Apr 2, 2026

/retest

@jukie jukie merged commit e802fd4 into envoyproxy:main Apr 2, 2026
57 of 59 checks passed
@shahar-h shahar-h deleted the use-helm-tool branch April 2, 2026 21:12
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants