ci: fix broken go-benchmark-test#8663
Merged
zirain merged 3 commits intoenvoyproxy:mainfrom Apr 4, 2026
Merged
Conversation
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8663 +/- ##
==========================================
+ Coverage 74.46% 74.49% +0.02%
==========================================
Files 243 243
Lines 38670 38670
==========================================
+ Hits 28796 28806 +10
+ Misses 7879 7869 -10
Partials 1995 1995 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
jukie
approved these changes
Apr 3, 2026
Contributor
|
/retest |
skos-ninja
pushed a commit
to skos-ninja/envoy-gateway
that referenced
this pull request
May 1, 2026
* ci: fix broken go-benchmark-test Signed-off-by: Shahar Harari <shahar.harari@sap.com> * add back continue-on-error Signed-off-by: Shahar Harari <shahar.harari@sap.com> --------- Signed-off-by: Shahar Harari <shahar.harari@sap.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
go-benchmark-testCI job has been silently failing since #8161 moved tests into a separate Go module (test/go.mod). The Make target rango test ./test/gobenchfrom the root module, which doesn't contain that package.The failure was not noticed because the workflow step uses
continue-on-error: true.This PR fixes it by:
cd test && go test ... ./gobenchso it runs under the correct modulecontinue-on-error: truefor now since the benchmark comparison against main is currently broken; will remove in a follow-up PRAlso fixes a cosmetic issue:
package fuzz→package gobenchto match the directory name.Which issue(s) this PR fixes:
Fixes #