Skip to content

fix: followup for #8380#8666

Merged
rudrakhp merged 4 commits intoenvoyproxy:mainfrom
zirain:followup-8380
Apr 13, 2026
Merged

fix: followup for #8380#8666
rudrakhp merged 4 commits intoenvoyproxy:mainfrom
zirain:followup-8380

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Apr 3, 2026

  1. improve the status message
  2. allow to disable frontend.default validation on one HTTPS port
  3. invalid Gateway.spec.tls.backend.clientCertificateRef doesn't falls back to EnvoyProxy.spec.backendTLS

@zirain zirain requested a review from a team as a code owner April 3, 2026 03:57
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 3, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 1854db6
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69d718a61125210008c35c5c
😎 Deploy Preview https://deploy-preview-8666--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.37%. Comparing base (c7e21fa) to head (1854db6).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8666      +/-   ##
==========================================
+ Coverage   74.33%   74.37%   +0.03%     
==========================================
  Files         244      244              
  Lines       38774    38778       +4     
==========================================
+ Hits        28823    28841      +18     
+ Misses       7953     7941      -12     
+ Partials     1998     1996       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jukie
jukie previously approved these changes Apr 4, 2026
@zirain zirain requested a review from a team April 4, 2026 03:12
Comment thread internal/gatewayapi/contexts.go
zirain added 4 commits April 9, 2026 11:10
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Copy link
Copy Markdown
Contributor

@jukie jukie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@rudrakhp rudrakhp merged commit 9f25066 into envoyproxy:main Apr 13, 2026
59 of 61 checks passed
@zirain zirain deleted the followup-8380 branch April 13, 2026 06:42
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
* improve status message

Signed-off-by: zirain <zirain2009@gmail.com>

* allow to disable validation

Signed-off-by: zirain <zirain2009@gmail.com>

* address follow up for 8380

Signed-off-by: zirain <zirain2009@gmail.com>

* address TODO

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants