chore: pin npm tools#8672
Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom Apr 6, 2026
Merged
Conversation
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8672 +/- ##
==========================================
- Coverage 74.51% 74.50% -0.01%
==========================================
Files 243 243
Lines 38670 38670
==========================================
- Hits 28816 28813 -3
- Misses 7864 7866 +2
- Partials 1990 1991 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
zirain
reviewed
Apr 4, 2026
Contributor
Author
|
/retest |
zirain
approved these changes
Apr 5, 2026
skos-ninja
pushed a commit
to skos-ninja/envoy-gateway
that referenced
this pull request
May 1, 2026
* chore: pin npm tools Signed-off-by: Shahar Harari <shahar.harari@sap.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
OpenSSF Scorecard flagged unpinned npm commands in the CI workflow:
The Hugo Docs workflow installed
markdownlint-cliandlinkinatorvianpm install -gwithout a lockfile, meaning every run resolveddependencies at install time. This has several downsides:
integrity verification, which the OpenSSF Scorecard flags under
Pinned-Dependencies.
diverge when upstream packages publish new versions.
which Dependabot does not scan for npm version bumps.
This PR adds
tools/package.jsonandtools/package-lock.jsonto pinmarkdownlint-cliandlinkinatorwith full integrity hashes,updated to the latest versions (markdownlint-cli@0.48.0, linkinator@7.6.1)
to resolve known CVEs in transitive dependencies. The Make targets in
tools.mk,lint.mk, anddocs.mknow handle installation automaticallyvia
npm ci, so thenpm install -gsteps are removed from the CI workflow.Dependabot is configured to keep these packages up to date.
Which issue(s) this PR fixes:
N/A
Release Notes: No