Skip to content

build(site): use npm ci and clean up docs CI pipeline#8694

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
shahar-h:build/site-npm-ci
Apr 13, 2026
Merged

build(site): use npm ci and clean up docs CI pipeline#8694
arkodg merged 1 commit intoenvoyproxy:mainfrom
shahar-h:build/site-npm-ci

Conversation

@shahar-h
Copy link
Copy Markdown
Contributor

@shahar-h shahar-h commented Apr 7, 2026

What this PR does / why we need it:

Switch the docs build from npm install to npm ci for deterministic, reproducible dependency resolution.

  • Commit site/package-lock.json — removed it from site/.gitignore so the lockfile is tracked in version control.
  • Use npm ci instead of npm install in docs-gen target (tools/make/docs.mk). npm ci installs exactly what's in the lockfile and fails if it's out of sync with package.json.
  • Stop deleting package-lock.json in the docs.clean target, since it's now a tracked source file.
  • Remove standalone Hugo setup step from CI (docs.yaml) — Hugo is already provided via the hugo-extended npm package in package.json.
  • Use site/.nvmrc for Node version in CI instead of hardcoding node-version: '18'.

npm install can silently resolve different dependency versions across builds, leading to non-reproducible docs output. npm ci is faster in CI (skips dependency resolution) and guarantees the exact dependency tree from the lockfile.

Which issue(s) this PR fixes:

N/A

Release Notes: No

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner April 7, 2026 20:03
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 7, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 2ac8575
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69d56320c9bfd70008d10bba
😎 Deploy Preview https://deploy-preview-8694--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shahar-h shahar-h requested review from Copilot and removed request for a team April 7, 2026 20:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the docs build process by switching from npm install to npm ci for deterministic dependency resolution, commits the package-lock.json file to version control, and simplifies the CI pipeline by removing redundant Hugo setup since Hugo is already provided via the hugo-extended npm package.

Changes:

  • Switch from npm install to npm ci in the docs build target for reproducible builds in CI
  • Commit site/package-lock.json to version control (removed from .gitignore) to ensure exact dependency pinning
  • Remove the standalone Hugo installation step from CI workflow as Hugo is provided via the hugo-extended npm package
  • Use site/.nvmrc for specifying Node version in CI instead of hardcoding node-version: '18'

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tools/make/docs.mk Changed npm install to npm ci and removed package-lock.json deletion from clean target
site/.gitignore Removed package-lock.json from gitignore to track lockfile in version control
site/package-lock.json Added complete lockfile with pinned dependency versions for reproducible builds
.github/workflows/docs.yaml Removed standalone Hugo setup step and switched to node-version-file configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.32%. Comparing base (c3d06fa) to head (2ac8575).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8694      +/-   ##
==========================================
- Coverage   74.34%   74.32%   -0.03%     
==========================================
  Files         244      244              
  Lines       38768    38768              
==========================================
- Hits        28824    28814      -10     
- Misses       7950     7958       +8     
- Partials     1994     1996       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg arkodg merged commit bbdb718 into envoyproxy:main Apr 13, 2026
44 of 45 checks passed
@shahar-h shahar-h deleted the build/site-npm-ci branch April 13, 2026 07:21
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants