Skip to content

fix: force HTTP1 for upstream connections for WS and WSS backends#8699

Open
zhaohuabing wants to merge 3 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-8693
Open

fix: force HTTP1 for upstream connections for WS and WSS backends#8699
zhaohuabing wants to merge 3 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-8693

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Apr 8, 2026

This PR forces forces HTTP/1.1 upstream connections instead of negotiating HTTP/2 for ws and wss Backend appProtocols. This change avoids compatibility issues with WebSocket backends that do not support RFC 8441 extended CONNECT.

Fixes: #8693

@zhaohuabing zhaohuabing requested a review from a team as a code owner April 8, 2026 10:34
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 22bf777
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69d7025b8d5afd000894c3af

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.35%. Comparing base (082b038) to head (22bf777).

Files with missing lines Patch % Lines
internal/ir/xds.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8699      +/-   ##
==========================================
- Coverage   74.36%   74.35%   -0.01%     
==========================================
  Files         244      244              
  Lines       38768    38802      +34     
==========================================
+ Hits        28828    28853      +25     
- Misses       7947     7952       +5     
- Partials     1993     1997       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing marked this pull request as ready for review April 8, 2026 11:04
@zhaohuabing zhaohuabing marked this pull request as draft April 8, 2026 11:12
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review April 9, 2026 01:24
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WSS -> WSS handling

1 participant