Skip to content

oidc: native oauth2 per-route config#8703

Merged
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:oauth2-per-route-config
Apr 13, 2026
Merged

oidc: native oauth2 per-route config#8703
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:oauth2-per-route-config

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Apr 9, 2026

This PR leverages Envoy’s newly introduced native per-route configuration to configure the OAuth2 filter for SecurityPolicies.

With native per-route config, only a dumb OAuth2 filter is added to the listener’s HCM filter chain, while the actual configuration is pushed to the route level. As a result, CRUD operations on SecurityPolicies no longer trigger listener churn.

@zhaohuabing zhaohuabing requested a review from a team as a code owner April 9, 2026 05:42
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 9, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit d9593f1
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69dc3b72209bee0008c0acde

@zhaohuabing zhaohuabing marked this pull request as draft April 9, 2026 05:42
@zhaohuabing zhaohuabing force-pushed the oauth2-per-route-config branch from ee7b228 to 24269fc Compare April 9, 2026 05:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.41%. Comparing base (40b3dbf) to head (d9593f1).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/oidc.go 68.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8703      +/-   ##
==========================================
+ Coverage   74.34%   74.41%   +0.06%     
==========================================
  Files         244      244              
  Lines       38868    38866       -2     
==========================================
+ Hits        28896    28921      +25     
+ Misses       7970     7948      -22     
+ Partials     2002     1997       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhaohuabing zhaohuabing force-pushed the oauth2-per-route-config branch 5 times, most recently from 98d67b0 to 18b2f4e Compare April 10, 2026 04:22
@zhaohuabing zhaohuabing marked this pull request as ready for review April 10, 2026 04:30
@zhaohuabing zhaohuabing force-pushed the oauth2-per-route-config branch 2 times, most recently from 2961327 to cd68c4b Compare April 10, 2026 08:14
@zhaohuabing zhaohuabing requested a review from arkodg April 10, 2026 08:14
@zhaohuabing
Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@zhaohuabing
Copy link
Copy Markdown
Member Author

/retest

license.override = ["Apache-2.0"]
reason = "This package is dual-licensed: the code under the Apache 2.0 license and the documentation under the CC-BY-SA-4.0 license"

# TODO: Remove this override after github.com/envoyproxy/go-control-plane v0.14.1 is released.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team April 12, 2026 15:01
@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Apr 12, 2026
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zirain zirain force-pushed the oauth2-per-route-config branch from cd68c4b to d9593f1 Compare April 13, 2026 00:40
@zhaohuabing zhaohuabing merged commit 0a81122 into envoyproxy:main Apr 13, 2026
59 of 61 checks passed
@zhaohuabing zhaohuabing deleted the oauth2-per-route-config branch April 13, 2026 03:09
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
native oauth2 per-route config

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants