ExtAuth: allow passing Route metadata to Ext Auth#8723
ExtAuth: allow passing Route metadata to Ext Auth#8723zhaohuabing merged 4 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8723 +/- ##
==========================================
- Coverage 74.31% 74.29% -0.03%
==========================================
Files 245 245
Lines 38801 38804 +3
==========================================
- Hits 28835 28829 -6
- Misses 7963 7971 +8
- Partials 2003 2004 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
force-pushed
the
api-6686
branch
2 times, most recently
from
95f61c8 to
bfe1eec
Compare
|
Can we extend the ext-auth e2e test to parse the content and add it as a header? other than that, LGTM. |
Sure, I can do that. If the API looks good, I'll go ahead with the implementation. |
zhaohuabing
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f04db60fa9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/retest |
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
4 participants
Sine EG is using a fixed metadata namespace
envoy-gateway,IncludeRouteMetadata *boolprobably is good enough for passing the route metadata to the Ext Auth. cc @arkodg @guydcImplement #6686