Skip to content

ci: optimize binary builds in build_and_test workflow#8777

Merged
jukie merged 2 commits intoenvoyproxy:mainfrom
shahar-h:optimize-binary-build
Apr 17, 2026
Merged

ci: optimize binary builds in build_and_test workflow#8777
jukie merged 2 commits intoenvoyproxy:mainfrom
shahar-h:optimize-binary-build

Conversation

@shahar-h
Copy link
Copy Markdown
Contributor

@shahar-h shahar-h commented Apr 16, 2026

What this PR does / why we need it:

  • Build job now only builds the envoy-gateway binary (not egctl), with conditional platforms: linux/amd64 only on PRs and release branches, both linux/amd64 and linux/arm64 on main (needed for multi-arch image publish).
  • egctl is built in a new parallel build-egctl job for linux/amd64 only.
  • benchmark-test and resilience-test now download the pre-built binary artifact (same as conformance/e2e), avoiding a redundant go build.
  • Added SKIP_GO_BUILD Make variable to golang.mk: when set to true, the go.build.% target skips compilation. All downstream jobs that download the pre-built artifact set SKIP_GO_BUILD=true so the Make dependency chain (kube-install-imageimage.buildgo.build) no longer triggers a redundant rebuild.
  • Use chmod +x bin/linux/*/envoy-gateway wildcard across all jobs instead of listing each architecture explicitly.

Which issue(s) this PR fixes:

Fixes #8686

Release Notes: No

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner April 16, 2026 21:46
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 16, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit b285886
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e158c03c8ad3000811a0d5
😎 Deploy Preview https://deploy-preview-8777--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.32%. Comparing base (faf7a99) to head (b285886).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8777   +/-   ##
=======================================
  Coverage   74.32%   74.32%           
=======================================
  Files         245      245           
  Lines       38801    38804    +3     
=======================================
+ Hits        28837    28841    +4     
+ Misses       7962     7961    -1     
  Partials     2002     2002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahar-h
Copy link
Copy Markdown
Contributor Author

@codex

@shahar-h shahar-h changed the title ci: optimize binary builds in CI workflow ci: optimize binary builds in build_and_test workflow Apr 16, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@shahar-h
Copy link
Copy Markdown
Contributor Author

/retest

@jukie jukie merged commit 5ed1c4c into envoyproxy:main Apr 17, 2026
59 of 61 checks passed
@shahar-h shahar-h deleted the optimize-binary-build branch April 17, 2026 15:57
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
* ci: optimize binary builds in CI workflow

Signed-off-by: Shahar Harari <shahar.harari@sap.com>

* skip go build in downstream jobs

Signed-off-by: Shahar Harari <shahar.harari@sap.com>

---------

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize binary builds in build_and_test workflow

3 participants