[release/v1.7] add benchmark report for v1.7.2#8779
[release/v1.7] add benchmark report for v1.7.2#8779rudrakhp merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fe5637c39
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "p99": 0, | ||
| "p999": 0 |
There was a problem hiding this comment.
The new v1.7.2 benchmark dataset records p99 and p999 as 0 (and this pattern repeats across the file), which makes the dashboard report impossible 0ms tail latency whenever this version is selected. Because the charts and summaries consume these percentile fields directly, this silently misrepresents release performance and can hide regressions; these values look like placeholders/defaults that were never populated from the benchmark artifact.
Useful? React with 👍 / 👎.
rudrakhp
left a comment
rudrakhp
left a comment
There was a problem hiding this comment.
@cnvergence you need to manually update the values for p99 and p999, the fix in tool was made in #8614 that we unfortunately didn't include in the cherry pick this time :(
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
* [release/v1.7] add benchmark report for v1.7.2 Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * [release/v1.7] manually add percentiles Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
3 participants
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No