feat: bandwidth limit#8862
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01117b8c50
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8862 +/- ##
==========================================
- Coverage 74.37% 74.35% -0.02%
==========================================
Files 246 247 +1
Lines 39292 39429 +137
==========================================
+ Hits 29222 29316 +94
- Misses 8040 8065 +25
- Partials 2030 2048 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkk777-7
force-pushed
the
feat-bandwidth
branch
2 times, most recently
from
e933dd5 to
45fa6c6
Compare
kkk777-7
force-pushed
the
feat-bandwidth
branch
from
45fa6c6 to
522f861
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45fa6c6a39
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 522f861d4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
kkk777-7
force-pushed
the
feat-bandwidth
branch
from
a0612ac to
dd0cb7a
Compare
zhaohuabing
left a comment
zhaohuabing
left a comment
There was a problem hiding this comment.
This finding is reported by codex, is it true?
Now that bandwidthLimit is no longer hidden, users can set response.responseTrailers.prefix to strings containing \n, \r, or NUL. The Envoy BandwidthLimit proto rejects response_trailer_prefix unless it matches ^[^\\x00\\n\\r]*$, but the CRD currently accepts the value and buildBandwidthLimit copies it straight into xDS. That can make an accepted BackendTrafficPolicy produce invalid xDS instead of being rejected at admission or translated into a policy status error. Add the same kubebuilder/CEL validation here and cover it in test/cel-validation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
|
@zhaohuabing
I've added CRD validation and cel-test. |
|
/retest |
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
|
/retest |
* feat: bandwidth limit Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: crd validation Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
* feat: bandwidth limit Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: crd validation Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
3 participants
What this PR does / why we need it:
Implemented bandwidth limit. follow-up #8630
envoy related document: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/bandwidth_limit/v3/bandwidth_limit.proto#envoy-v3-api-msg-extensions-filters-http-bandwidth-limit-v3-bandwidthlimit
Which issue(s) this PR fixes:
Fixes #4328
Release Notes: Yes