update otel and fix failing tests#1078
Merged
collin-lee merged 1 commit intoenvoyproxy:mainfrom Mar 12, 2026
Merged
Conversation
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Revolyssup
force-pushed
the
revolyssup/update-otel-fix
branch
from
d677588 to
992569f
Compare
collin-lee
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After otel upgrade, existing tests fail here #1076
Reason:
require (which calls runtime.Goexit()) inside assert.Eventually is fundamentally broken. Eventually runs the condition in a goroutine. When require fails, Goexit() kills that goroutine without sending a result back on the channel. This permanently deadlocks Eventually's retry loop. It can never retry and just waits until the timeout fires. In otel's previous version the test succeeded on first assertion so this case was never hit.
Fix: Replaced require calls inside assert.Eventually with conditional checks that return false, allowing proper retry behavior. For TestFlushGauge (which doesn't use Eventually), switched from require to assert since the require import was removed.
Notes: This is a known issue and currently has an outstanding PR stretchr/testify#1819
But it looks like it's going nowhere. In the meanwhile, this fix makes sure that otel can be upgraded with passing tests.