Cannot convert a Symbol value to a string #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Dec 14, 2017
src/ReactTestWrapper.js
Outdated
| inspect () { | ||
| const root = this.root() | ||
| const name = root.name() || '???' | ||
| const name = (root.name() || '???').toString() |
Member
There was a problem hiding this comment.
String(x) is always better than x.toString()
src/ShallowTestWrapper.js
Outdated
| const rootInstance = root.instance() | ||
| const rootType = rootInstance && rootInstance.constructor | ||
| const name = rootType ? getDisplayName(rootType) : (root.name() || '???') | ||
| const name = (rootType ? getDisplayName(rootType) : (root.name() || '???')).toString() |
test/inspect.test.js
Outdated
| expect(String(inspect(shallow(<DisplayNameSyntax />).find('div')))).to.equal('the node in <DisplayNameSyntax />') | ||
| expect(String(inspect(shallow(<DisplayNameSyntax />).find('span')))).to.equal('the node in <DisplayNameSyntax />') | ||
| expect(String(inspect(shallow(<div />)))).to.equal('<div />') | ||
| expect(String(inspect(shallow(<SymbolComponent />)))).to.equal(`<${SymbolComponent.displayName.toString()} />`) |
|
Oh, thanks for fixing! I wish there would be a new release with this fix included... |
eugenet8k
added a commit
to lookout/chai-enzyme
that referenced
this pull request
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always convert the name to string when in
ShallowTestWrapper#inspectandReactTestWrapper#inspectso it still works for components that have aSymbolas adisplayName.Since
nameis always gonna be defined I think it is fine to just call.toString, although some logic could be added to look for justSymbolinstances.#214