shallow render error messages now only show components under test #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e first level components)
ljharb
changed the title
ljharb
approved these changes
May 11, 2018
|
|
||
| html () { | ||
| return this.wrapper.html() | ||
| return this.wrapper.debug().replace(/\n(\s*)/g, '') |
Contributor
Author
There was a problem hiding this comment.
When I updated it to debug() a few of the html() tests were failing:
AssertionError: expected the node in <Fixture /> to be '<span id="child">Test</span>', but it was '<span id="child">\n Test\n</span>'
This change removed that extra padding and the \n's to get them to match what they use to be. I took the regex from the jest-enzyme link I posted in the #218.
Let me know if you'd rather it be the other way and I can update those tests and remove the regex!
Contributor
Author
|
How does one get a pull request merged in and pushed out as a new version to npm? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the first level components)
Fixes #218.