Skip to content

Conversation

@SailingSteve
Copy link

@SailingSteve SailingSteve commented May 6, 2021

Initial checkin to support React 17

@ljharb
Copy link
Member

ljharb commented May 6, 2021

React 17 support is blocked on there being an official react 17 enzyme adapter.

@perrin4869
Copy link

hm... recent npm versions fail to install without the --legacy-peer-deps flag or --force flag
I've been using chai-enzyme just fine with v17 and the unofficial adapter by wojtekmaj...
Even without the official adapter, I think support for react 17 isn't realistically going to need changes in this module?

@ljharb
Copy link
Member

ljharb commented May 10, 2022

@perrin4869 it needs this module to test on react 17.

@perrin4869
Copy link

Would it be acceptable to test using the unofficial module for now?

@ljharb
Copy link
Member

ljharb commented May 10, 2022

No; if the unofficial adapter passed tests, there'd be an official adapter.

@perrin4869
Copy link

Well, in this case it would just need to be good enough to pass the tests in this repo though right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants