Revert "🎨 Redesign PopoverMainView — unified scrollable actions list (issue #294)"#312
Merged
Merged
Conversation
…(issue #…" This reverts commit 2aa5e95.
|
Skipping CodeAnt AI review — this PR is a revert. The diff is the inverse of code that was previously reviewed and merged, so a fresh review typically adds no signal. If you want CodeAnt to double-check the revert, comment |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesUI Consolidation & Pagination Removal
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Review Summary by QodoRevert PopoverMainView redesign to restore stable layout
WalkthroughsDescription• Reverts PR #309 redesign that introduced regressions • Restores inline popover layout with system stats, actions, jobs sections • Removes complex action expansion/pagination logic • Consolidates subview components back into main file Diagramflowchart LR
A["PR #309 Redesign<br/>with ScrollView"] -->|Revert| B["Inline Layout<br/>with Sections"]
B --> C["System Stats"]
B --> D["Actions List"]
B --> E["Active Jobs"]
B --> F["Quit Button"]
File Changes1. Sources/RunnerBar/PopoverMainView.swift
|
Code Review by Qodo
1. Undefined systemStats.start()
|
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
173
to
176
| .onAppear { | ||
| isAuthenticated = (githubToken() != nil) | ||
| systemStats.start() | ||
| } |
There was a problem hiding this comment.
1. Undefined systemstats.start() 🐞 Bug ≡ Correctness
PopoverMainView calls systemStats.start(), but SystemStatsViewModel does not define a start() method, causing a compilation failure. This blocks the app from building.
Agent Prompt
### Issue description
`PopoverMainView` calls `systemStats.start()`, but `SystemStatsViewModel` has no `start()` method, which will fail compilation.
### Issue Context
`SystemStatsViewModel` currently creates its repeating `Timer` in `init()`. You can either (a) add a `start()` API (and likely move timer creation out of `init()`), or (b) remove the call to `start()` and rely on `init()` (not recommended because it keeps polling even when popover is closed).
### Fix Focus Areas
- Sources/RunnerBar/PopoverMainView.swift[172-176]
- Sources/RunnerBar/SystemStats.swift[70-86]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This was referenced May 10, 2026
Open
Closed
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #309
Summary by CodeRabbit