Fix/popover scrollview jobs display (design-branch-1)

.gitignore

@@ -0,0 +1,2 @@
+.build
+dist

.swiftlint.yml

@@ -8,7 +8,7 @@ excluded:
   - .build
   - Package.swift
 
-# ── Opt-in rules ────────────────────────────────────────────────────────────────────────
+# ── Opt-in rules ────────────────────────────────────────────────────────────────────────────────────
 opt_in_rules:
   - missing_docs           # require /// on all internal/public declarations
   - closure_spacing        # consistent spacing inside closure braces
@@ -23,7 +23,7 @@ opt_in_rules:
   - empty_collection_literal  # prefer isEmpty over == []
   - first_where            # prefer first(where:) over filter().first
 
-# ── Rule configuration ───────────────────────────────────────────────────────────────────
+# ── Rule configuration ─────────────────────────────────────────────────────────────────────────────────────
 missing_docs:
   warning:
     - internal
@@ -40,7 +40,7 @@ line_length:
   ignores_urls: true
 
 file_length:
-  warning: 400
+  warning: 500
   error: 600
 
 type_body_length:
@@ -61,7 +61,7 @@ nesting:
   function_level:
     warning: 3
 
-# ── Disabled rules ───────────────────────────────────────────────────────────────────────
+# ── Disabled rules ──────────────────────────────────────────────────────────────────────────────────────
 disabled_rules:
   - todo          # TODOs are acceptable during active development
   - trailing_comma  # SwiftPM/Xcode auto-formatter conflicts with this

Sources/RunnerBar/ActionDetailView.swift

@@ -3,46 +3,34 @@ import SwiftUI
 // swiftlint:disable identifier_name vertical_whitespace_opening_braces superfluous_disable_command
 
 // ═══════════════════════════════════════════════════════════════════════════════
-// ⚠️ REGRESSION GUARD — mirrors JobDetailView frame/layout contract
+// ⚠️ REGRESSION GUARD
 // ═══════════════════════════════════════════════════════════════════════════════
 //
-// ── FRAME CONTRACT ──────────────────────────────────────────────────────────────────────────────────────
-//   Receives the same FIXED frame from AppDelegate as JobDetailView.
-//   Sized once at openPopover() from mainView()'s fittingSize; never changes.
-//   ScrollView absorbs overflow — do NOT fight the frame.
-//
-// ── LAYOUT RULES ────────────────────────────────────────────────────────────────────────────────────────
-//   ✔ Root: .frame(maxWidth: .infinity, maxHeight: .infinity, alignment: .top)
-//   ✔ Job list MUST be inside ScrollView
-//   ✔ Header (back button + title + Divider) MUST be OUTSIDE ScrollView
-//   ❌ NEVER put header inside ScrollView
-//   ❌ NEVER add .idealWidth or .frame(height:) to root
-//   ❌ NEVER call navigate() directly — use onBack / onSelectJob callbacks
+// Height is driven by AppDelegate.openPopover() fittingSize — read once per open.
+// fittingSize works correctly because the VStack inside ScrollView uses
+// .fixedSize(horizontal: false, vertical: true) — tells SwiftUI the content
+// wants its ideal (content-driven) height. DO NOT remove that modifier.
+// Header is OUTSIDE ScrollView. Job list is INSIDE ScrollView.
+// ❌ NEVER remove .maxHeight:.infinity from root — detail views are shown via
+//    navigate() AFTER show(), so they must fill the existing popover frame.
+//    Removing it causes a frame mismatch that makes AppKit jump the popover sideways.
+// ❌ NEVER remove .fixedSize(horizontal:false,vertical:true) from ScrollView VStack.
+// ❌ NEVER call navigate() directly — use onBack / onSelectJob callbacks.
+// ❌ NEVER call layoutSubtreeIfNeeded() anywhere — causes sideways jump.
 // ═══════════════════════════════════════════════════════════════════════════════
 
-/// Navigation level 2a (Actions path): shows the flat job list for a commit/PR group.
-///
-/// Drill-down chain:
-///   PopoverMainView (action row tap)
-///   → ActionDetailView            ← this view
-///   → JobDetailView (step list)   ← existing, unchanged
-///   → StepLogView (log)           ← existing, unchanged
 struct ActionDetailView: View {
     let group: ActionGroup
     let onBack: () -> Void
-    /// Called when user taps a job row. AppDelegate wires this to detailViewFromAction(job:group:).
     let onSelectJob: (ActiveJob) -> Void
 
-    /// Drives the live elapsed timer every second.
     @State private var tick = 0
-    /// Held so we can invalidate on disappear and prevent timer accumulation
-    /// when the user navigates away and back (AppDelegate swaps rootView each time).
     @State private var tickTimer: Timer?
 
     var body: some View {
         VStack(alignment: .leading, spacing: 0) {
 
-            // ── Header: OUTSIDE ScrollView — always visible at top
+            // ── Header: OUTSIDE ScrollView
             HStack(spacing: 6) {
                 Button(action: onBack) {
                     HStack(spacing: 3) {
@@ -53,7 +41,7 @@ struct ActionDetailView: View {
                     .fixedSize()
                 }
                 .buttonStyle(.plain)
-                Spacer()  // ⚠️ load-bearing — pushes elapsed to right edge
+                Spacer()
                 ReRunButton(
                     action: { completion in
                         let scope = group.repo
@@ -124,6 +112,9 @@ struct ActionDetailView: View {
             Divider()
 
             // ── Jobs list: INSIDE ScrollView
+            // ⚠️ .fixedSize(horizontal:false,vertical:true) on the VStack is LOAD-BEARING.
+            // It tells SwiftUI this content wants its ideal height, so AppDelegate's
+            // fittingSize read returns the correct content height. DO NOT remove.
             ScrollView(.vertical, showsIndicators: true) {
                 VStack(alignment: .leading, spacing: 0) {
                     if group.jobs.isEmpty {
@@ -136,15 +127,17 @@ struct ActionDetailView: View {
                         ForEach(group.jobs) { job in
                             Button(action: { onSelectJob(job) }, label: {
                                 HStack(spacing: 8) {
-                                    Circle()
-                                        .fill(jobDotColor(for: job))
-                                        .frame(width: 7, height: 7)
+                                    PieProgressView(
+                                        progress: job.progressFraction,
+                                        color: jobDotColor(for: job),
+                                        size: 7
+                                    )
                                     Text(job.name)
                                         .font(.system(size: 12))
                                         .foregroundColor(job.isDimmed ? .secondary : .primary)
                                         .lineLimit(1)
                                         .truncationMode(.tail)
-                                    Spacer()  // ⚠️ load-bearing
+                                    Spacer()
                                     if let conclusion = job.conclusion {
                                         Text(conclusionLabel(conclusion))
                                             .font(.caption)
@@ -172,9 +165,12 @@ struct ActionDetailView: View {
                         }
                     }
                 }
+                .fixedSize(horizontal: false, vertical: true)
                 .frame(maxWidth: .infinity, alignment: .leading)
             }
         }
+        // ⚠️ REGRESSION GUARD: maxHeight:.infinity is REQUIRED — detail views are shown
+        // via navigate() AFTER show(), so they must fill the existing popover frame.
         .frame(maxWidth: .infinity, maxHeight: .infinity, alignment: .top)
         .onAppear {
             tickTimer?.invalidate()
@@ -188,11 +184,14 @@ struct ActionDetailView: View {
 
     private func elapsedLive(tick _: Int) -> String { group.elapsed }
 
-    // MARK: - Job row helpers
-
     private func jobDotColor(for job: ActiveJob) -> Color {
-        if job.isDimmed { return .secondary }
-        return job.status == "in_progress" ? .yellow : .gray
+        switch job.status {
+        case "in_progress": return .yellow
+        case "queued":      return .blue
+        default:
+            if job.isDimmed { return .gray }
+            return job.conclusion == "success" ? .green : .red
+        }
     }
 
     private func jobStatusLabel(for job: ActiveJob) -> String {

Sources/RunnerBar/ActionGroup.swift

@@ -1,5 +1,5 @@
 import Foundation
-// swiftlint:disable opening_brace identifier_name missing_docs orphaned_doc_comment
+// swiftlint:disable opening_brace identifier_name orphaned_doc_comment
 
 // MARK: - GroupStatus
 
@@ -20,10 +20,15 @@
 /// Holds only the data needed for display and job fetching — deliberately
 /// minimal so the full job list lives on the parent ActionGroup instead.
 struct WorkflowRunRef: Identifiable {
+    /// Unique GitHub run identifier.
     let id: Int
-    let name: String         // workflow file name, e.g. "SonarQube", "vitest"
+    /// Workflow file name, e.g. "SonarQube", "vitest".
+    let name: String
+    /// Current run status: `queued`, `in_progress`, or `completed`.
     let status: String
+    /// Final outcome when status is `completed`.
     let conclusion: String?
+    /// URL to the run's page on github.com.
     let htmlUrl: String?
 }
 
@@ -58,6 +63,7 @@
     /// Timestamps derived from job data, not run-level API fields.
     /// Mirrors ci-dash.py's `first_job_started_at` / `last_job_completed_at`.
     var firstJobStartedAt: Date?
+    /// Last job completion time across all runs in this group.
     var lastJobCompletedAt: Date?
 
     /// Fallback creation time from the representative run.
@@ -116,77 +122,66 @@
 
     /// Name of the first in-progress job, or first queued, or "—".
     var currentJobName: String {
-        if let j = jobs.first(where: { $0.status == "in_progress" }) { return j.name }
-        if let j = jobs.first(where: { $0.status == "queued" })      { return j.name }
+        if let job = jobs.first(where: { $0.status == "in_progress" }) { return job.name }
+        if let job = jobs.first(where: { $0.status == "queued" })      { return job.name }
         return "—"
     }
 
+    /// How long ago the group started, as a short human string, e.g. "3m ago", "1h ago".
+    /// Uses `firstJobStartedAt` when available, falls back to `createdAt`.
+    /// Returns "—" if neither timestamp is available.
+    /// Delegates to `RelativeTimeFormatter` for testable, injectable formatting.
+    var startedAgo: String {
+        guard let ref = firstJobStartedAt ?? createdAt else { return "—" }
+        return RelativeTimeFormatter.string(from: ref)
+    }
+
     /// Elapsed time derived from min(job.startedAt) → max(job.completedAt).
     var elapsed: String {
         if let start = firstJobStartedAt {
             let end = lastJobCompletedAt ?? Date()
             let sec = Int(end.timeIntervalSince(start))
             guard sec >= 0 else { return "00:00" }
-            let m = sec / 60; let s = sec % 60
-            return String(format: "%02d:%02d", m, s)
+            let minutes = sec / 60; let seconds = sec % 60
+            return String(format: "%02d:%02d", minutes, seconds)
         }
         guard let start = createdAt else { return "00:00" }
         let sec = Int(Date().timeIntervalSince(start))
         guard sec >= 0 else { return "00:00" }
-        let m = sec / 60; let s = sec % 60
-        return String(format: "%02d:%02d", m, s)
+        let minutes = sec / 60; let seconds = sec % 60
+        return String(format: "%02d:%02d", minutes, seconds)
     }
-}
 
-// MARK: - Codable helpers (private to this file)
-
-private struct ActionRunsResponse: Codable {
-    let workflowRuns: [RunPayload]
-    enum CodingKeys: String, CodingKey { case workflowRuns = "workflow_runs" }
-}
-
-private struct RunPayload: Codable {
-    let id: Int
-    let name: String
-    let status: String
-    let conclusion: String?
-    let headBranch: String?
-    let headSha: String
-    let displayTitle: String?
-    let createdAt: String?
-    let updatedAt: String?
-    let htmlUrl: String?
-    let headCommit: HeadCommit?
-    let pullRequests: [PRRef]?
-
-    enum CodingKeys: String, CodingKey {
-        case id, name, status, conclusion
-        case headBranch = "head_branch"
-        case headSha = "head_sha"
-        case displayTitle = "display_title"
-        case createdAt = "created_at"
-        case updatedAt = "updated_at"
-        case htmlUrl = "html_url"
-        case headCommit = "head_commit"
-        case pullRequests = "pull_requests"
+    // MARK: - Progress fraction (model layer — keeps view bodies clean)
+
+    /// Completion fraction 0.0–1.0 for the pie-progress dot, or `nil` (indeterminate)
+    /// when status is queued or no job data is available.
+    ///
+    /// - `nil`  → indeterminate (queued / no jobs loaded yet)
+    /// - `1.0`  → completed
+    /// - `0..<1` → partial (jobsDone / jobsTotal)
+    var progressFraction: Double? {
+        switch groupStatus {
+        case .queued:    return nil
+        case .completed: return 1.0
+        case .inProgress:
+            guard jobsTotal > 0 else { return nil }
+            return Double(jobsDone) / Double(jobsTotal)
+        }
     }
 }
 
-private struct HeadCommit: Codable { let message: String }
-private struct PRRef: Codable { let number: Int }
-
-// MARK: - PR label
+// MARK: - Equatable
 
-/// Derives the short identifier for an action group row.
-/// Priority: PR number → branch-embedded number → sha[:7].
-private func prLabel(from run: RunPayload) -> String {
-    if let pr = run.pullRequests?.first { return "#\(pr.number)" }
-    if let branch = run.headBranch,
-       let range = branch.range(of: #"/(\d+)/"#, options: .regularExpression) {
-        let digits = branch[range].filter { $0.isNumber }
-        return "#\(digits)"
+extension ActionGroup: Equatable {
+    /// Returns `true` when two groups have the same ID, dimmed state, job list, and run IDs.
+    // swiftlint:disable:next missing_docs
+    static func == (lhs: ActionGroup, rhs: ActionGroup) -> Bool {
+        lhs.id == rhs.id
+            && lhs.isDimmed == rhs.isDimmed
+            && lhs.jobs == rhs.jobs
+            && lhs.runs.map({ $0.id }) == rhs.runs.map({ $0.id })
     }
-    return String(run.headSha.prefix(7))
 }
 
 // MARK: - Fetch + Group
@@ -195,7 +190,7 @@
 /// enriches each group with its flattened job list, and returns groups sorted:
 /// in_progress first, then queued, then done — newest first.
 // swiftlint:disable:next function_body_length cyclomatic_complexity
 func fetchActionGroups(for scope: String, cache: [String: ActionGroup] = [:]) -> [ActionGroup] {
     guard scope.contains("/") else {
         log("fetchActionGroups › skipping org scope \(scope)")
         return []
@@ -299,27 +294,27 @@
 // MARK: - Private helpers
 
 /// Constructs an `ActiveJob` from a decoded `JobPayload`.
-func makeActiveJob(from j: JobPayload, iso: ISO8601DateFormatter,
+func makeActiveJob(from payload: JobPayload, iso: ISO8601DateFormatter,
                    isDimmed: Bool = false) -> ActiveJob {
-    let steps: [JobStep] = (j.steps ?? []).enumerated().map { idx, s in
+    let steps: [JobStep] = (payload.steps ?? []).enumerated().map { idx, step in
         JobStep(
             id: idx + 1,
-            name: s.name,
-            status: s.status,
-            conclusion: s.conclusion,
-            startedAt: s.startedAt.flatMap { iso.date(from: $0) },
-            completedAt: s.completedAt.flatMap { iso.date(from: $0) }
+            name: step.name,
+            status: step.status,
+            conclusion: step.conclusion,
+            startedAt: step.startedAt,
+            completedAt: step.completedAt
         )
     }
     return ActiveJob(
-        id: j.id,
-        name: j.name,
-        status: j.status,
-        conclusion: j.conclusion,
-        startedAt: j.startedAt.flatMap { iso.date(from: $0) },
-        createdAt: j.createdAt.flatMap { iso.date(from: $0) },
-        completedAt: j.completedAt.flatMap { iso.date(from: $0) },
-        htmlUrl: j.htmlUrl,
+        id: payload.id,
+        name: payload.name,
+        status: payload.status,
+        conclusion: payload.conclusion,
+        startedAt: payload.startedAt.flatMap { iso.date(from: $0) },
+        createdAt: payload.createdAt.flatMap { iso.date(from: $0) },
+        completedAt: payload.completedAt.flatMap { iso.date(from: $0) },
+        htmlUrl: payload.htmlUrl,
         isDimmed: isDimmed,
         steps: steps
     )
@@ -381,4 +376,4 @@
     case .completed:  return 2
     }
 }
-// swiftlint:enable opening_brace identifier_name missing_docs orphaned_doc_comment
+// swiftlint:enable opening_brace identifier_name orphaned_doc_comment