Skip to content

Improve reference checking code #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve reference checking code #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eos_pre_commit_hooks/eos_test_check_references.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import os
import re
import subprocess
import yaml
from typing import Sequence

def eos_test_check_references(
Expand Down Expand Up @@ -33,13 +34,12 @@ def eos_test_check_references(

# regexp for correctly formed reference
# See eos/utils/reference-name.cc
good_reference_regexp = re.compile(r'\[[a-zA-Z0-9][a-zA-Z0-9+-]*:[0-9]{4}[A-Z]\]')
# Use capturing group to get only the reference, not the external square brackets
good_reference_regexp = re.compile(r'\[([a-zA-Z0-9][a-zA-Z0-9+-]*:[0-9]{4}[A-Z])\]')

# Read in all references from references.yaml
known_refs = set()
with open("eos/references.yaml") as f:
for line in f:
known_refs.update(good_reference_regexp.findall(line))
known_refs = set(yaml.safe_load(f))


for filename in filenames_filtered:
Expand Down